Title: [88279] trunk/Source/WebCore
- Revision
- 88279
- Author
- [email protected]
- Date
- 2011-06-07 16:02:20 -0700 (Tue, 07 Jun 2011)
Log Message
2011-06-07 Jer Noble <[email protected]>
Reviewed by Eric Carlson.
Video with poster attribute will not display new frames when scrubbing.
https://bugs.webkit.org/show_bug.cgi?id=62036
Remove our "detection" about the end of a scrub now that there is an explicit seek completion
handler available in AVFoundation. Move what we used to do upon detection in timeChanged()
into seekCompleted().
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88278 => 88279)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 22:51:20 UTC (rev 88278)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 23:02:20 UTC (rev 88279)
@@ -1,3 +1,18 @@
+2011-06-07 Jer Noble <[email protected]>
+
+ Reviewed by Eric Carlson.
+
+ Video with poster attribute will not display new frames when scrubbing.
+ https://bugs.webkit.org/show_bug.cgi?id=62036
+
+ Remove our "detection" about the end of a scrub now that there is an explicit seek completion
+ handler available in AVFoundation. Move what we used to do upon detection in timeChanged()
+ into seekCompleted().
+
+ * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+ (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
+ (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
+
2011-06-07 James Simonsen <[email protected]>
Unreviewed, build fix, missing files from r88274.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (88278 => 88279)
--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2011-06-07 22:51:20 UTC (rev 88278)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2011-06-07 23:02:20 UTC (rev 88279)
@@ -551,29 +551,15 @@
void MediaPlayerPrivateAVFoundation::timeChanged(double time)
{
LOG(Media, "MediaPlayerPrivateAVFoundation::timeChanged(%p) - time = %f", this, time);
-
- if (m_seekTo == invalidTime())
- return;
-
- // AVFoundation may call our observer more than once during a seek, and we can't currently tell
- // if we will be able to seek to an exact time, so assume that we are done seeking if we are
- // "close enough" to the seek time.
- const double smallSeekDelta = 1.0 / 100;
-
- float currentRate = rate();
- if ((currentRate > 0 && time >= m_seekTo) || (currentRate < 0 && time <= m_seekTo) || (abs(m_seekTo - time) <= smallSeekDelta)) {
- m_seekTo = invalidTime();
- updateStates();
- m_player->timeChanged();
- }
}
void MediaPlayerPrivateAVFoundation::seekCompleted(bool finished)
{
LOG(Media, "MediaPlayerPrivateAVFoundation::seekCompleted(%p) - finished = %d", this, finished);
- if (finished)
- m_seekTo = invalidTime();
+ m_seekTo = invalidTime();
+ updateStates();
+ m_player->timeChanged();
}
void MediaPlayerPrivateAVFoundation::didEnd()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
