Title: [88339] trunk/Source/WebKit/qt
- Revision
- 88339
- Author
- [email protected]
- Date
- 2011-06-08 05:52:34 -0700 (Wed, 08 Jun 2011)
Log Message
2011-06-08 Andreas Kling <[email protected]>
Reviewed by Benjamin Poulain.
[Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
https://bugs.webkit.org/show_bug.cgi?id=62274
Vector::find() returns size_t (which is unsigned), so we should check
for WTF::notFound instead of -1.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
Modified Paths
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (88338 => 88339)
--- trunk/Source/WebKit/qt/ChangeLog 2011-06-08 12:18:12 UTC (rev 88338)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-06-08 12:52:34 UTC (rev 88339)
@@ -1,3 +1,16 @@
+2011-06-08 Andreas Kling <[email protected]>
+
+ Reviewed by Benjamin Poulain.
+
+ [Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
+ https://bugs.webkit.org/show_bug.cgi?id=62274
+
+ Vector::find() returns size_t (which is unsigned), so we should check
+ for WTF::notFound instead of -1.
+
+ * WebCoreSupport/FrameLoaderClientQt.cpp:
+ (WebCore::FrameLoaderClientQt::createPlugin):
+
2011-06-07 Noam Rosenthal <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (88338 => 88339)
--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-06-08 12:18:12 UTC (rev 88338)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-06-08 12:52:34 UTC (rev 88339)
@@ -1625,7 +1625,7 @@
const bool isQWebView = client && qobject_cast<QWidget*>(client->pluginParent());
#if defined(MOZ_PLATFORM_MAEMO) && (MOZ_PLATFORM_MAEMO >= 5)
size_t wmodeIndex = params.find("wmode");
- if (wmodeIndex == -1) {
+ if (wmodeIndex == WTF::notFound) {
// Disable XEmbed mode and force it to opaque mode.
params.append("wmode");
values.append("opaque");
@@ -1637,7 +1637,7 @@
if (!isQWebView) {
// Inject wmode=opaque when there is no client or the client is not a QWebView.
size_t wmodeIndex = params.find("wmode");
- if (wmodeIndex == -1) {
+ if (wmodeIndex == WTF::notFound) {
params.append("wmode");
values.append("opaque");
} else if (equalIgnoringCase(values[wmodeIndex], "window"))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
