Title: [88403] trunk/Source/WebCore
- Revision
- 88403
- Author
- [email protected]
- Date
- 2011-06-08 16:25:39 -0700 (Wed, 08 Jun 2011)
Log Message
2011-06-08 Brian Salomon <[email protected]>
Reviewed by James Robinson.
Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
https://bugs.webkit.org/show_bug.cgi?id=62318
Chromium-only crash
Failures takes multiple seconds to occur, relying on JS garbage-collection to occur
http://www.hotbazooka.com/privatejoe-large
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88402 => 88403)
--- trunk/Source/WebCore/ChangeLog 2011-06-08 23:13:07 UTC (rev 88402)
+++ trunk/Source/WebCore/ChangeLog 2011-06-08 23:25:39 UTC (rev 88403)
@@ -1,3 +1,17 @@
+2011-06-08 Brian Salomon <[email protected]>
+
+ Reviewed by James Robinson.
+
+ Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
+ https://bugs.webkit.org/show_bug.cgi?id=62318
+
+ Chromium-only crash
+ Failures takes multiple seconds to occur, relying on JS garbage-collection to occur
+ http://www.hotbazooka.com/privatejoe-large
+
+ * platform/graphics/gpu/DrawingBuffer.cpp:
+ (WebCore::DrawingBuffer::clear):
+
2011-06-08 Emil A Eklund <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp (88402 => 88403)
--- trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp 2011-06-08 23:13:07 UTC (rev 88402)
+++ trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp 2011-06-08 23:25:39 UTC (rev 88403)
@@ -84,12 +84,10 @@
}
if (m_multisampleFBO) {
- m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_multisampleFBO);
m_context->deleteFramebuffer(m_multisampleFBO);
m_multisampleFBO = 0;
}
- m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, m_fbo);
m_context->deleteFramebuffer(m_fbo);
m_fbo = 0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
