Title: [88457] trunk/Source/WebKit/chromium
- Revision
- 88457
- Author
- [email protected]
- Date
- 2011-06-09 09:20:46 -0700 (Thu, 09 Jun 2011)
Log Message
2011-06-09 Nico Weber <[email protected]>
Reviewed by Darin Fisher.
[chromium] Make a few destructors private.
https://bugs.webkit.org/show_bug.cgi?id=62341
No intended functionality change.
* src/NotificationPresenterImpl.cpp:
(WebKit::VoidCallbackClient::~VoidCallbackClient):
* src/WebTextCheckingCompletionImpl.h:
(WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
* src/WebURLRequest.cpp:
(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88456 => 88457)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-09 16:15:29 UTC (rev 88456)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-09 16:20:46 UTC (rev 88457)
@@ -1,3 +1,21 @@
+2011-06-09 Nico Weber <[email protected]>
+
+ Reviewed by Darin Fisher.
+
+ [chromium] Make a few destructors private.
+ https://bugs.webkit.org/show_bug.cgi?id=62341
+
+ No intended functionality change.
+
+ * src/NotificationPresenterImpl.cpp:
+ (WebKit::VoidCallbackClient::~VoidCallbackClient):
+ * src/WebTextCheckingCompletionImpl.h:
+ (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
+ * src/WebURLRequest.cpp:
+ (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
+ * src/WebURLResponse.cpp:
+ (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
+
2011-06-09 James Robinson <[email protected]>
Fix chromium build on build.webkit.org builders.
Modified: trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp (88456 => 88457)
--- trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp 2011-06-09 16:15:29 UTC (rev 88456)
+++ trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp 2011-06-09 16:20:46 UTC (rev 88457)
@@ -56,8 +56,6 @@
{
}
- virtual ~VoidCallbackClient() { }
-
virtual void permissionRequestComplete()
{
if (m_callback)
@@ -66,6 +64,8 @@
}
private:
+ virtual ~VoidCallbackClient() { }
+
RefPtr<VoidCallback> m_callback;
};
Modified: trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h (88456 => 88457)
--- trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h 2011-06-09 16:15:29 UTC (rev 88456)
+++ trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h 2011-06-09 16:20:46 UTC (rev 88457)
@@ -46,11 +46,11 @@
{
}
- virtual ~WebTextCheckingCompletionImpl() { }
-
virtual void didFinishCheckingText(const WebVector<WebTextCheckingResult>&);
private:
+ virtual ~WebTextCheckingCompletionImpl() { }
+
int m_identifier;
WebCore::SpellChecker* m_spellChecker;
};
Modified: trunk/Source/WebKit/chromium/src/WebURLRequest.cpp (88456 => 88457)
--- trunk/Source/WebKit/chromium/src/WebURLRequest.cpp 2011-06-09 16:15:29 UTC (rev 88456)
+++ trunk/Source/WebKit/chromium/src/WebURLRequest.cpp 2011-06-09 16:20:46 UTC (rev 88457)
@@ -79,10 +79,11 @@
m_allowStoredCredentials = p->m_allowStoredCredentials;
}
+ virtual void dispose() { delete this; }
+
+private:
virtual ~WebURLRequestPrivateImpl() { }
- virtual void dispose() { delete this; }
-
ResourceRequest m_resourceRequestAllocation;
};
Modified: trunk/Source/WebKit/chromium/src/WebURLResponse.cpp (88456 => 88457)
--- trunk/Source/WebKit/chromium/src/WebURLResponse.cpp 2011-06-09 16:15:29 UTC (rev 88456)
+++ trunk/Source/WebKit/chromium/src/WebURLResponse.cpp 2011-06-09 16:20:46 UTC (rev 88457)
@@ -62,10 +62,11 @@
m_resourceResponse = &m_resourceResponseAllocation;
}
+ virtual void dispose() { delete this; }
+
+private:
virtual ~WebURLResponsePrivateImpl() { }
- virtual void dispose() { delete this; }
-
ResourceResponse m_resourceResponseAllocation;
};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
