Title: [88461] trunk
- Revision
- 88461
- Author
- [email protected]
- Date
- 2011-06-09 11:09:30 -0700 (Thu, 09 Jun 2011)
Log Message
2011-06-09 Chang Shu <[email protected]>
Reviewed by Andreas Kling.
[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381
Unskip passed tests.
* platform/qt-wk2/Skipped:
2011-06-09 Chang Shu <[email protected]>
Reviewed by Andreas Kling.
[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381
Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
QWKPagePrivate::isViewFocused() will check it later.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (88460 => 88461)
--- trunk/LayoutTests/ChangeLog 2011-06-09 18:05:57 UTC (rev 88460)
+++ trunk/LayoutTests/ChangeLog 2011-06-09 18:09:30 UTC (rev 88461)
@@ -1,3 +1,14 @@
+2011-06-09 Chang Shu <[email protected]>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
+ https://bugs.webkit.org/show_bug.cgi?id=62381
+
+ Unskip passed tests.
+
+ * platform/qt-wk2/Skipped:
+
2011-06-08 Abhishek Arya <[email protected]>
Reviewed by Ryosuke Niwa.
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (88460 => 88461)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-06-09 18:05:57 UTC (rev 88460)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-06-09 18:09:30 UTC (rev 88461)
@@ -3104,73 +3104,6 @@
# New test introduced in http://trac.webkit.org/changeset/85818
editing/pasteboard/paste-placeholder-input.html
-# unskipped by r86357, but fail on Qt-WK2 platform
-# Missing shouldBeginEditingInDOMRange:range and webViewDidBeginEditing:WebViewDidBeginEditingNotification
-editing/inserting/4278698.html
-editing/inserting/editable-html-element.html
-editing/inserting/editing-empty-divs.html
-editing/inserting/insert-div-023.html
-editing/inserting/multiple-lines-selected.html
-
-# unskipped by r86374, but fail on Qt-WK2 platform
-# Missing shouldBeginEditingInDOMRange:range and webViewDidBeginEditing:WebViewDidBeginEditingNotification
-editing/pasteboard/4076267-2.html
-editing/pasteboard/4076267.html
-editing/pasteboard/4806874.html
-editing/pasteboard/5387578.html
-editing/pasteboard/bad-placeholder.html
-editing/pasteboard/block-wrappers-necessary.html
-editing/pasteboard/input-field-1.html
-editing/pasteboard/nested-blocks-with-text-area.html
-editing/pasteboard/nested-blocks-with-text-field.html
-editing/pasteboard/paste-text-008.html
-editing/pasteboard/smart-paste-008.html
-
-# unskipped by r86376, but fail on Qt-WK2 platform
-# Missing shouldBeginEditingInDOMRange:range and webViewDidBeginEditing:WebViewDidBeginEditingNotification
-editing/execCommand/4580583-1.html
-editing/execCommand/4580583-2.html
-editing/execCommand/4641880-1.html
-editing/execCommand/4641880-2.html
-editing/execCommand/4747450.html
-editing/execCommand/4916402.html
-editing/execCommand/4916541.html
-editing/execCommand/4924441.html
-editing/execCommand/5080333-1.html
-editing/execCommand/5080333-2.html
-editing/execCommand/5136770.html
-editing/execCommand/5138441.html
-editing/execCommand/5142012-1.html
-editing/execCommand/5142012-2.html
-editing/execCommand/5190926.html
-editing/execCommand/5481523.html
-editing/execCommand/5482023.html
-editing/execCommand/5569741.html
-editing/execCommand/create-list-with-hr.html
-editing/execCommand/find-after-replace.html
-editing/execCommand/findString-2.html
-editing/execCommand/findString.html
-editing/execCommand/format-block.html
-editing/execCommand/format-block-with-braces.html
-editing/execCommand/format-block-with-trailing-br.html
-editing/execCommand/hilitecolor.html
-editing/execCommand/indent-empty-root.html
-editing/execCommand/insert-list-and-stitch.html
-editing/execCommand/indent-list-item.html
-editing/execCommand/indent-paragraphs.html
-editing/execCommand/indent-selection.html
-editing/execCommand/insertHorizontalRule.html
-editing/execCommand/insertImage.html
-editing/execCommand/nsresponder-indent.html
-editing/execCommand/nsresponder-outdent.html
-editing/execCommand/outdent-selection.html
-editing/execCommand/paste-1.html
-editing/execCommand/paste-2.html
-editing/execCommand/print.html
-editing/execCommand/remove-list-from-range-selection.html
-editing/execCommand/remove-list-item-1.html
-editing/execCommand/selectAll.html
-
# [Qt]REGRESSION(86499): GC related bug
# https://bugs.webkit.org/show_bug.cgi?id=60881
fast/js/array-sort-modifying-tostring.html
Modified: trunk/Tools/ChangeLog (88460 => 88461)
--- trunk/Tools/ChangeLog 2011-06-09 18:05:57 UTC (rev 88460)
+++ trunk/Tools/ChangeLog 2011-06-09 18:09:30 UTC (rev 88461)
@@ -1,3 +1,16 @@
+2011-06-09 Chang Shu <[email protected]>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
+ https://bugs.webkit.org/show_bug.cgi?id=62381
+
+ Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
+ QWKPagePrivate::isViewFocused() will check it later.
+
+ * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+ (WTR::PlatformWebView::PlatformWebView):
+
2011-06-09 Robert Hogan <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp (88460 => 88461)
--- trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2011-06-09 18:05:57 UTC (rev 88460)
+++ trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2011-06-09 18:09:30 UTC (rev 88461)
@@ -60,6 +60,10 @@
m_view->setParent(m_window);
m_window->setCentralWidget(m_view);
m_window->setGeometry(0, 0, 800, 600);
+
+ QFocusEvent ev(QEvent::WindowActivate);
+ QApplication::sendEvent(m_view->scene(), &ev);
+ m_view->wkView()->setFocus(Qt::OtherFocusReason);
}
PlatformWebView::~PlatformWebView()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
