Title: [88465] trunk/Tools
- Revision
- 88465
- Author
- [email protected]
- Date
- 2011-06-09 11:21:23 -0700 (Thu, 09 Jun 2011)
Log Message
2011-06-09 Noel Gordon <[email protected]>
Reviewed by Tony Chang.
Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721
The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
calls to mean the plugin handled the event.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventWin): Return 0 for each event on windows.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (88464 => 88465)
--- trunk/Tools/ChangeLog 2011-06-09 18:19:38 UTC (rev 88464)
+++ trunk/Tools/ChangeLog 2011-06-09 18:21:23 UTC (rev 88465)
@@ -1,3 +1,16 @@
+2011-06-09 Noel Gordon <[email protected]>
+
+ Reviewed by Tony Chang.
+
+ Test plugin should support event logging on the windows port.
+ https://bugs.webkit.org/show_bug.cgi?id=61721
+
+ The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
+ calls to mean the plugin handled the event.
+
+ * DumpRenderTree/TestNetscapePlugIn/main.cpp:
+ (handleEventWin): Return 0 for each event on windows.
+
2011-06-09 Chang Shu <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp (88464 => 88465)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp 2011-06-09 18:19:38 UTC (rev 88464)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp 2011-06-09 18:21:23 UTC (rev 88465)
@@ -687,15 +687,15 @@
case WM_PAINT:
if (obj->onPaintEvent)
executeScript(obj, obj->onPaintEvent);
- return 1;
+ break;
case WM_KEYDOWN:
if (obj->eventLogging)
pluginLog(instance, "keyDown '%c'", event->wParam);
if (obj->evaluateScriptOnMouseDownOrKeyDown && !obj->mouseDownForEvaluateScript)
executeScript(obj, obj->evaluateScriptOnMouseDownOrKeyDown);
- return 1;
+ break;
case WM_CHAR:
- return 1;
+ break;
case WM_KEYUP:
if (obj->eventLogging)
pluginLog(instance, "keyUp '%c'", event->wParam);
@@ -704,7 +704,7 @@
obj->testKeyboardFocusForPlugins = FALSE;
executeScript(obj, "layoutTestController.notifyDone();");
}
- return 1;
+ break;
case WM_LBUTTONDOWN:
case WM_MBUTTONDOWN:
case WM_RBUTTONDOWN:
@@ -712,21 +712,21 @@
pluginLog(instance, "mouseDown at (%d, %d)", LOWORD(event->lParam), HIWORD(event->lParam));
if (obj->evaluateScriptOnMouseDownOrKeyDown && obj->mouseDownForEvaluateScript)
executeScript(obj, obj->evaluateScriptOnMouseDownOrKeyDown);
- return 1;
+ break;
case WM_LBUTTONUP:
case WM_MBUTTONUP:
case WM_RBUTTONUP:
if (obj->eventLogging)
pluginLog(instance, "mouseUp at (%d, %d)", LOWORD(event->lParam), HIWORD(event->lParam));
- return 1;
+ break;
case WM_SETFOCUS:
if (obj->eventLogging)
pluginLog(instance, "getFocusEvent");
- return 1;
+ break;
case WM_KILLFOCUS:
if (obj->eventLogging)
pluginLog(instance, "loseFocusEvent");
- return 1;
+ break;
}
return 0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
