Title: [88528] trunk/Source/WebCore
- Revision
- 88528
- Author
- [email protected]
- Date
- 2011-06-10 00:10:53 -0700 (Fri, 10 Jun 2011)
Log Message
2011-06-09 Jer Noble <[email protected]>
Reviewed by Darin Adler.
REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=62402
Sites are able to override the "overflow:hidden" rule for root full-screen nodes
simply by adding a "html {}" rule. Make this rule !important, and also make it apply
to root nodes who are merely ancestors of full-screen elements, to cover the case of
a root node containing an <iframe> whose contents have gone full-screen.
* css/fullscreen.css:
(:root:-webkit-full-screen-document:not(:-webkit-full-screen),
:root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
who are full-screen ancestors, and make them !important.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88527 => 88528)
--- trunk/Source/WebCore/ChangeLog 2011-06-10 06:42:57 UTC (rev 88527)
+++ trunk/Source/WebCore/ChangeLog 2011-06-10 07:10:53 UTC (rev 88528)
@@ -1,3 +1,20 @@
+2011-06-09 Jer Noble <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
+ https://bugs.webkit.org/show_bug.cgi?id=62402
+
+ Sites are able to override the "overflow:hidden" rule for root full-screen nodes
+ simply by adding a "html {}" rule. Make this rule !important, and also make it apply
+ to root nodes who are merely ancestors of full-screen elements, to cover the case of
+ a root node containing an <iframe> whose contents have gone full-screen.
+
+ * css/fullscreen.css:
+ (:root:-webkit-full-screen-document:not(:-webkit-full-screen),
+ :root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
+ who are full-screen ancestors, and make them !important.
+
2011-06-09 Luke Macpherson <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/css/fullscreen.css (88527 => 88528)
--- trunk/Source/WebCore/css/fullscreen.css 2011-06-10 06:42:57 UTC (rev 88527)
+++ trunk/Source/WebCore/css/fullscreen.css 2011-06-10 07:10:53 UTC (rev 88528)
@@ -3,8 +3,8 @@
z-index:2147483647;
}
-:root:-webkit-full-screen-document:not(:-webkit-full-screen) {
- overflow:hidden;
+:root:-webkit-full-screen-document:not(:-webkit-full-screen), :root:-webkit-full-screen-ancestor {
+ overflow:hidden !important;
}
:-webkit-full-screen-ancestor:not(iframe) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
