Title: [88598] trunk/Tools
- Revision
- 88598
- Author
- [email protected]
- Date
- 2011-06-10 23:04:28 -0700 (Fri, 10 Jun 2011)
Log Message
2011-06-10 Ryosuke Niwa <[email protected]>
Reviewed by Ojan Vafai.
new-run-webkit-tests: 'images' links on results.html don't work
https://bugs.webkit.org/show_bug.cgi?id=62194
Use relative path when generating images-diffs.html
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
Added _output_testname.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (88597 => 88598)
--- trunk/Tools/ChangeLog 2011-06-11 05:52:29 UTC (rev 88597)
+++ trunk/Tools/ChangeLog 2011-06-11 06:04:28 UTC (rev 88598)
@@ -1,3 +1,15 @@
+2011-06-10 Ryosuke Niwa <[email protected]>
+
+ Reviewed by Ojan Vafai.
+
+ new-run-webkit-tests: 'images' links on results.html don't work
+ https://bugs.webkit.org/show_bug.cgi?id=62194
+
+ Use relative path when generating images-diffs.html
+
+ * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+ Added _output_testname.
+
2011-06-10 Lucas Forschler <[email protected]>
Reviewed by Stephanie Lewis.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (88597 => 88598)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-06-11 05:52:29 UTC (rev 88597)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-06-11 06:04:28 UTC (rev 88598)
@@ -132,6 +132,10 @@
output_filename = fs.join(self._root_output_dir, self._testname)
return fs.splitext(output_filename)[0] + modifier
+ def _output_testname(self, modifier):
+ fs = self._port._filesystem
+ return fs.splitext(fs.basename(self._testname))[0] + modifier
+
def write_output_files(self, file_type, output, expected):
"""Writes the test output, the expected output in the results directory.
@@ -241,7 +245,7 @@
toggleImages();
setInterval(toggleImages, 2000)
</script>
-""" % { 'title': self._testname, 'diff_filename': self.output_filename('-diff.png'), 'prefix': self.output_filename('') }
+""" % { 'title': self._testname, 'diff_filename': self._output_testname('-diff.png'), 'prefix': self._output_testname('') }
self._port._filesystem.write_binary_file(diffs_html_filename, html)
return True
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
