[webkit-changes] [88600] trunk/Source/WebCore

Fri, 10 Jun 2011 23:45:39 -0700

Title: [88600] trunk/Source/WebCore
Revision
88600
Author
[email protected]
Date
2011-06-10 23:45:02 -0700 (Fri, 10 Jun 2011)

Log Message

2011-06-10  Adam Barth  <[email protected]>

        Remove bogus ASSERTs.  These ASSERTs used to be correct before I
        changed DocumentWriter to put the onus for ignoring empty writes onto
        the parser.

        This patch should stop these test from triggering ASSERTs:

        plugins/plugin-document-back-forward.html
        plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
        userscripts/user-script-plugin-document.html

        * html/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::appendBytes):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::appendBytes):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (88599 => 88600)


--- trunk/Source/WebCore/ChangeLog	2011-06-11 06:23:20 UTC (rev 88599)
+++ trunk/Source/WebCore/ChangeLog	2011-06-11 06:45:02 UTC (rev 88600)
@@ -1,3 +1,20 @@
+2011-06-10  Adam Barth  <[email protected]>
+
+        Remove bogus ASSERTs.  These ASSERTs used to be correct before I
+        changed DocumentWriter to put the onus for ignoring empty writes onto
+        the parser.
+
+        This patch should stop these test from triggering ASSERTs:
+
+        plugins/plugin-document-back-forward.html
+        plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
+        userscripts/user-script-plugin-document.html
+
+        * html/MediaDocument.cpp:
+        (WebCore::MediaDocumentParser::appendBytes):
+        * html/PluginDocument.cpp:
+        (WebCore::PluginDocumentParser::appendBytes):
+
 2011-06-09  Jer Noble  <[email protected]>
 
         Reviewed by Darin Adler.

Modified: trunk/Source/WebCore/html/MediaDocument.cpp (88599 => 88600)


--- trunk/Source/WebCore/html/MediaDocument.cpp	2011-06-11 06:23:20 UTC (rev 88599)
+++ trunk/Source/WebCore/html/MediaDocument.cpp	2011-06-11 06:45:02 UTC (rev 88600)
@@ -105,7 +105,6 @@
 
 void MediaDocumentParser::appendBytes(DocumentWriter*, const char*, int, bool)
 {
-    ASSERT(!m_mediaElement);
     if (m_mediaElement)
         return;

Modified: trunk/Source/WebCore/html/PluginDocument.cpp (88599 => 88600)


--- trunk/Source/WebCore/html/PluginDocument.cpp	2011-06-11 06:23:20 UTC (rev 88599)
+++ trunk/Source/WebCore/html/PluginDocument.cpp	2011-06-11 06:45:02 UTC (rev 88600)
@@ -105,7 +105,6 @@
 
 void PluginDocumentParser::appendBytes(DocumentWriter*, const char*, int, bool)
 {
-    ASSERT(!m_embedElement);
     if (m_embedElement)
         return;
 

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to