Title: [88602] trunk
- Revision
- 88602
- Author
- [email protected]
- Date
- 2011-06-11 10:12:52 -0700 (Sat, 11 Jun 2011)
Log Message
2011-06-11 Dimitri Glazkov <[email protected]>
Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401
Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
* storage/indexeddb/setVersion-undefined-expected.txt: Removed.
* storage/indexeddb/setVersion-undefined.html: Removed.
2011-06-11 Dimitri Glazkov <[email protected]>
Unreviewed, rolling out r88565.
http://trac.webkit.org/changeset/88565
https://bugs.webkit.org/show_bug.cgi?id=62401
Broke Chromium browser test:
IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setVersion):
* storage/IDBDatabase.idl:
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (88601 => 88602)
--- trunk/LayoutTests/ChangeLog 2011-06-11 16:37:59 UTC (rev 88601)
+++ trunk/LayoutTests/ChangeLog 2011-06-11 17:12:52 UTC (rev 88602)
@@ -1,3 +1,15 @@
+2011-06-11 Dimitri Glazkov <[email protected]>
+
+ Unreviewed, rolling out r88565.
+ http://trac.webkit.org/changeset/88565
+ https://bugs.webkit.org/show_bug.cgi?id=62401
+
+ Broke Chromium browser test:
+ IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
+
+ * storage/indexeddb/setVersion-undefined-expected.txt: Removed.
+ * storage/indexeddb/setVersion-undefined.html: Removed.
+
2011-06-10 Abhishek Arya <[email protected]>
Reviewed by Simon Fraser.
Deleted: trunk/LayoutTests/storage/indexeddb/setVersion-undefined-expected.txt (88601 => 88602)
--- trunk/LayoutTests/storage/indexeddb/setVersion-undefined-expected.txt 2011-06-11 16:37:59 UTC (rev 88601)
+++ trunk/LayoutTests/storage/indexeddb/setVersion-undefined-expected.txt 2011-06-11 17:12:52 UTC (rev 88602)
@@ -1,25 +0,0 @@
-Test IndexedDB version string is required and can not be null
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
-PASS indexedDB == null is false
-IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;
-PASS IDBDatabaseException == null is false
-IDBCursor = window.IDBCursor || window.webkitIDBCursor;
-PASS IDBCursor == null is false
-IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
-PASS IDBKeyRange == null is false
-indexedDB.open(name, description)
-db = event.target.result
-Expecting exception from db.setVersion();
-PASS Exception was thrown.
-PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
-Expecting exception from db.setVersion(null);
-PASS Exception was thrown.
-PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/storage/indexeddb/setVersion-undefined.html (88601 => 88602)
--- trunk/LayoutTests/storage/indexeddb/setVersion-undefined.html 2011-06-11 16:37:59 UTC (rev 88601)
+++ trunk/LayoutTests/storage/indexeddb/setVersion-undefined.html 2011-06-11 17:12:52 UTC (rev 88602)
@@ -1,51 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<link rel="stylesheet" href=""
-<script src=""
-<script src=""
-<script src=""
-</head>
-<body>
-<p id="description"></p>
-<div id="console"></div>
-<script>
-
-description("Test IndexedDB version string is required and can not be null");
-if (window.layoutTestController)
- layoutTestController.waitUntilDone();
-
-function test()
-{
- indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");
- shouldBeFalse("indexedDB == null");
- IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;");
- shouldBeFalse("IDBDatabaseException == null");
- IDBCursor = evalAndLog("IDBCursor = window.IDBCursor || window.webkitIDBCursor;");
- shouldBeFalse("IDBCursor == null");
- IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
- shouldBeFalse("IDBKeyRange == null");
-
- name = window.location.pathname;
- description = "My Test Database";
- request = evalAndLog("indexedDB.open(name, description)");
- request._onsuccess_ = openSuccess;
- request._onerror_ = unexpectedErrorCallback;
-}
-
-function openSuccess()
-{
- db = evalAndLog("db = event.target.result");
-
- request = evalAndExpectException("db.setVersion();", "IDBDatabaseException.NON_TRANSIENT_ERR");
- request = evalAndExpectException("db.setVersion(null);", "IDBDatabaseException.NON_TRANSIENT_ERR");
- done();
-}
-
-var successfullyParsed = true;
-
-test();
-
-</script>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (88601 => 88602)
--- trunk/Source/WebCore/ChangeLog 2011-06-11 16:37:59 UTC (rev 88601)
+++ trunk/Source/WebCore/ChangeLog 2011-06-11 17:12:52 UTC (rev 88602)
@@ -1,3 +1,16 @@
+2011-06-11 Dimitri Glazkov <[email protected]>
+
+ Unreviewed, rolling out r88565.
+ http://trac.webkit.org/changeset/88565
+ https://bugs.webkit.org/show_bug.cgi?id=62401
+
+ Broke Chromium browser test:
+ IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest
+
+ * storage/IDBDatabase.cpp:
+ (WebCore::IDBDatabase::setVersion):
+ * storage/IDBDatabase.idl:
+
2011-06-10 Abhishek Arya <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebCore/storage/IDBDatabase.cpp (88601 => 88602)
--- trunk/Source/WebCore/storage/IDBDatabase.cpp 2011-06-11 16:37:59 UTC (rev 88601)
+++ trunk/Source/WebCore/storage/IDBDatabase.cpp 2011-06-11 17:12:52 UTC (rev 88602)
@@ -105,11 +105,6 @@
PassRefPtr<IDBVersionChangeRequest> IDBDatabase::setVersion(ScriptExecutionContext* context, const String& version, ExceptionCode& ec)
{
- if (version.isNull()) {
- ec = IDBDatabaseException::NON_TRANSIENT_ERR;
- return 0;
- }
-
RefPtr<IDBVersionChangeRequest> request = IDBVersionChangeRequest::create(context, IDBAny::create(this), version);
m_backend->setVersion(version, request, m_databaseCallbacks, ec);
return request;
Modified: trunk/Source/WebCore/storage/IDBDatabase.idl (88601 => 88602)
--- trunk/Source/WebCore/storage/IDBDatabase.idl 2011-06-11 16:37:59 UTC (rev 88601)
+++ trunk/Source/WebCore/storage/IDBDatabase.idl 2011-06-11 17:12:52 UTC (rev 88602)
@@ -43,7 +43,7 @@
raises (IDBDatabaseException);
void deleteObjectStore(in DOMString name)
raises (IDBDatabaseException);
- [CallWith=ScriptExecutionContext] IDBVersionChangeRequest setVersion(in [ConvertUndefinedOrNullToNullString] DOMString version)
+ [CallWith=ScriptExecutionContext] IDBVersionChangeRequest setVersion(in DOMString version)
raises (IDBDatabaseException);
[CallWith=ScriptExecutionContext] IDBTransaction transaction(in [Optional] DOMStringList storeNames, in [Optional] unsigned short mode)
raises (IDBDatabaseException);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
