Title: [88629] trunk/Source/WebCore
- Revision
- 88629
- Author
- [email protected]
- Date
- 2011-06-12 23:20:45 -0700 (Sun, 12 Jun 2011)
Log Message
2011-06-12 Jer Noble <[email protected]>
Reviewed by Darin Adler.
REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=62507
No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
webkitWillExitFullScreenForElement() to be able to test this.
If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
containsFullScreenElement property removed. To protect against this, reset the property by calling
setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().
* dom/Document.cpp:
(WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88628 => 88629)
--- trunk/Source/WebCore/ChangeLog 2011-06-13 05:15:19 UTC (rev 88628)
+++ trunk/Source/WebCore/ChangeLog 2011-06-13 06:20:45 UTC (rev 88629)
@@ -1,3 +1,21 @@
+2011-06-12 Jer Noble <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
+ https://bugs.webkit.org/show_bug.cgi?id=62507
+
+ No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
+ webkitWillExitFullScreenForElement() to be able to test this.
+
+ If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
+ fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
+ containsFullScreenElement property removed. To protect against this, reset the property by calling
+ setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().
+
+ * dom/Document.cpp:
+ (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.
+
2011-06-12 Adam Barth <[email protected]>
Reviewed by Alexey Proskuryakov.
Modified: trunk/Source/WebCore/dom/Document.cpp (88628 => 88629)
--- trunk/Source/WebCore/dom/Document.cpp 2011-06-13 05:15:19 UTC (rev 88628)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-06-13 06:20:45 UTC (rev 88629)
@@ -4916,6 +4916,7 @@
void Document::fullScreenElementRemoved()
{
+ setContainsFullScreenElementRecursively(m_fullScreenElement->parentElement() ? m_fullScreenElement->parentElement() : ownerElement(), false);
webkitCancelFullScreen();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
