Title: [88667] trunk/Source/WebKit2
- Revision
- 88667
- Author
- [email protected]
- Date
- 2011-06-13 11:59:45 -0700 (Mon, 13 Jun 2011)
Log Message
REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
<rdar://problem/9580237>
Reviewed by Darin Adler.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::shouldUseSelection):
Return early if the selection we are using is not a range.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (88666 => 88667)
--- trunk/Source/WebKit2/ChangeLog 2011-06-13 18:58:25 UTC (rev 88666)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-13 18:59:45 UTC (rev 88667)
@@ -1,3 +1,14 @@
+2011-06-13 Sam Weinig <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
+ <rdar://problem/9580237>
+
+ * WebProcess/WebPage/mac/WebPageMac.mm:
+ (WebKit::shouldUseSelection):
+ Return early if the selection we are using is not a range.
+
2011-06-13 Tony Chang <[email protected]>
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (88666 => 88667)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2011-06-13 18:58:25 UTC (rev 88666)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2011-06-13 18:59:45 UTC (rev 88667)
@@ -424,6 +424,9 @@
static bool shouldUseSelection(const VisiblePosition& position, const VisibleSelection& selection)
{
+ if (!selection.isRange())
+ return false;
+
RefPtr<Range> selectedRange = selection.toNormalizedRange();
if (!selectedRange)
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
