Title: [88710] trunk/Source/WebKit/efl
Revision
88710
Author
[email protected]
Date
2011-06-13 15:22:48 -0700 (Mon, 13 Jun 2011)

Log Message

2011-06-13  Grzegorz Czajkowski  <[email protected]>

        Reviewed by Eric Seidel.

        [EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
        https://bugs.webkit.org/show_bug.cgi?id=62365

        These functions do not exist in any public headers and
        they are not used internally.
        Moreover ewk_view has the same functionality added
        https://bugs.webkit.org/show_bug.cgi?id=60435

        * ewk/ewk_frame.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (88709 => 88710)


--- trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:22:16 UTC (rev 88709)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:22:48 UTC (rev 88710)
@@ -1,3 +1,17 @@
+2011-06-13  Grzegorz Czajkowski  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        [EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=62365
+
+        These functions do not exist in any public headers and
+        they are not used internally.
+        Moreover ewk_view has the same functionality added
+        https://bugs.webkit.org/show_bug.cgi?id=60435
+
+        * ewk/ewk_frame.cpp:
+
 2011-06-13  Raphael Kubo da Costa  <[email protected]>
 
         Reviewed by Kenneth Rohde Christiansen.

Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (88709 => 88710)


--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-06-13 22:22:16 UTC (rev 88709)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-06-13 22:22:48 UTC (rev 88710)
@@ -657,84 +657,7 @@
     return strdup(s.data());
 }
 
-static inline Eina_Bool _ewk_frame_editor_command(Ewk_Frame_Smart_Data* sd, const char* command)
-{
-    return sd->frame->editor()->command(WTF::String::fromUTF8(command)).execute();
-}
-
 /**
- * Unselects whatever was selected.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_none(Evas_Object* o)
-{
-    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-    return _ewk_frame_editor_command(sd, "Unselect");
-}
-
-/**
- * Selects everything.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_all(Evas_Object* o)
-{
-    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-    return _ewk_frame_editor_command(sd, "SelectAll");
-}
-
-/**
- * Selects the current paragrah.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_paragraph(Evas_Object* o)
-{
-    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-    return _ewk_frame_editor_command(sd, "SelectParagraph");
-}
-
-/**
- * Selects the current sentence.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_sentence(Evas_Object* o)
-{
-    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-    return _ewk_frame_editor_command(sd, "SelectSentence");
-}
-
-/**
- * Selects the current line.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_line(Evas_Object* o)
-{
-    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-    return _ewk_frame_editor_command(sd, "SelectLine");
-}
-
-/**
- * Selects the current word.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_word(Evas_Object* o)
-{
-    EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-    EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-    return _ewk_frame_editor_command(sd, "SelectWord");
-}
-
-/**
  * Search the given text string in document.
  *
  * @param o frame object where to search text.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to