Title: [88716] trunk
Revision
88716
Author
[email protected]
Date
2011-06-13 15:36:45 -0700 (Mon, 13 Jun 2011)

Log Message

2011-06-13  Lucas De Marchi  <[email protected]>

        Reviewed by Eric Seidel.

        [CMAKE] Conditionally generate DerivedSources
        https://bugs.webkit.org/show_bug.cgi?id=62277

        Speedup build by not generating DerivedSources of features that are
        disabled. This was already been done for some features like ENABLE_SVG
        and now it's extended the following features: ENABLE_DATABASE,
        ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
        ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
        ENABLE_DATA_TRANSFER_ITEMS.

        * Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
2011-06-13  Lucas De Marchi  <[email protected]>

        Reviewed by Eric Seidel.

        [CMAKE] Conditionally generate DerivedSources
        https://bugs.webkit.org/show_bug.cgi?id=62277

        Speedup build by not generating DerivedSources of features that are
        disabled. This was already been done for some features like ENABLE_SVG
        and now it's extended the following features: ENABLE_DATABASE,
        ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
        ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
        ENABLE_DATA_TRANSFER_ITEMS.

        No change in functionality so no new tests.

        * CMakeLists.txt: move .idl files to be conditionally generated.

Modified Paths

Diff

Modified: trunk/ChangeLog (88715 => 88716)


--- trunk/ChangeLog	2011-06-13 22:32:47 UTC (rev 88715)
+++ trunk/ChangeLog	2011-06-13 22:36:45 UTC (rev 88716)
@@ -1,3 +1,19 @@
+2011-06-13  Lucas De Marchi  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        [CMAKE] Conditionally generate DerivedSources
+        https://bugs.webkit.org/show_bug.cgi?id=62277
+
+        Speedup build by not generating DerivedSources of features that are
+        disabled. This was already been done for some features like ENABLE_SVG
+        and now it's extended the following features: ENABLE_DATABASE,
+        ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
+        ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
+        ENABLE_DATA_TRANSFER_ITEMS.
+
+        * Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
+
 2011-06-10  Lucas De Marchi  <[email protected]>
 
         Reviewed by Kenneth Rohde Christiansen.

Modified: trunk/Source/WebCore/CMakeLists.txt (88715 => 88716)


--- trunk/Source/WebCore/CMakeLists.txt	2011-06-13 22:32:47 UTC (rev 88715)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-06-13 22:36:45 UTC (rev 88716)
@@ -137,7 +137,6 @@
     dom/Comment.idl
     dom/CompositionEvent.idl
     dom/CustomEvent.idl
-    dom/DataTransferItem.idl
     dom/DataTransferItems.idl
     dom/DeviceMotionEvent.idl
     dom/DeviceOrientationEvent.idl
@@ -176,7 +175,6 @@
     dom/ProgressEvent.idl
     dom/RangeException.idl
     dom/Range.idl
-    dom/StringCallback.idl
     dom/TextEvent.idl
     dom/Text.idl
     dom/TouchEvent.idl
@@ -316,8 +314,6 @@
     inspector/ScriptProfile.idl
     inspector/ScriptProfileNode.idl
 
-    loader/appcache/DOMApplicationCache.idl
-
     page/BarInfo.idl
     page/Console.idl
     page/Coordinates.idl
@@ -353,34 +349,6 @@
     plugins/DOMPlugin.idl
     plugins/DOMPluginArray.idl
 
-    storage/Database.idl
-    storage/DatabaseCallback.idl
-    storage/DatabaseSync.idl
-    storage/IDBAny.idl
-    storage/IDBCursor.idl
-    storage/IDBDatabaseError.idl
-    storage/IDBDatabaseException.idl
-    storage/IDBDatabase.idl
-    storage/IDBFactory.idl
-    storage/IDBIndex.idl
-    storage/IDBKey.idl
-    storage/IDBKeyRange.idl
-    storage/IDBObjectStore.idl
-    storage/IDBRequest.idl
-    storage/IDBTransaction.idl
-    storage/SQLError.idl
-    storage/SQLException.idl
-    storage/SQLResultSet.idl
-    storage/SQLResultSetRowList.idl
-    storage/SQLStatementCallback.idl
-    storage/SQLStatementErrorCallback.idl
-    storage/SQLTransaction.idl
-    storage/SQLTransactionCallback.idl
-    storage/SQLTransactionErrorCallback.idl
-    storage/SQLTransactionSync.idl
-    storage/SQLTransactionSyncCallback.idl
-    storage/Storage.idl
-    storage/StorageEvent.idl
     storage/StorageInfo.idl
     storage/StorageInfoErrorCallback.idl
     storage/StorageInfoQuotaCallback.idl
@@ -407,9 +375,6 @@
     webaudio/LowPass2FilterNode.idl
     webaudio/RealtimeAnalyserNode.idl
 
-    websockets/CloseEvent.idl
-    websockets/WebSocket.idl
-
     workers/AbstractWorker.idl
     workers/DedicatedWorkerContext.idl
     workers/SharedWorker.idl
@@ -424,11 +389,6 @@
     xml/XMLHttpRequestProgressEvent.idl
     xml/XMLHttpRequestUpload.idl
     xml/XMLSerializer.idl
-    xml/XPathEvaluator.idl
-    xml/XPathException.idl
-    xml/XPathExpression.idl
-    xml/XPathNSResolver.idl
-    xml/XPathResult.idl
     xml/XSLTProcessor.idl
 )
 
@@ -1458,10 +1418,28 @@
         platform/sql/SQLiteStatement.cpp
         platform/sql/SQLiteTransaction.cpp
     )
+    LIST(APPEND WebCore_IDL_FILES
+        storage/Database.idl
+        storage/DatabaseCallback.idl
+        storage/DatabaseSync.idl
+        storage/SQLError.idl
+        storage/SQLException.idl
+        storage/SQLResultSet.idl
+        storage/SQLResultSetRowList.idl
+        storage/SQLStatementCallback.idl
+        storage/SQLStatementErrorCallback.idl
+        storage/SQLTransaction.idl
+        storage/SQLTransactionCallback.idl
+        storage/SQLTransactionErrorCallback.idl
+        storage/SQLTransactionSync.idl
+        storage/SQLTransactionSyncCallback.idl
+    )
 ENDIF ()
 
 IF (ENABLE_DATA_TRANSFER_ITEMS)
     LIST(APPEND WebCore_IDL_FILES
+        dom/DataTransferItem.idl
+        dom/StringCallback.idl
     )
     LIST(APPEND WebCore_SOURCES
         dom/DataTransferItem.cpp
@@ -1470,6 +1448,30 @@
     )
 ENDIF ()
 
+IF (ENABLE_INDEXED_DATABASE)
+    LIST(APPEND WebCore_IDL_FILES
+        storage/IDBAny.idl
+        storage/IDBCursor.idl
+        storage/IDBDatabaseError.idl
+        storage/IDBDatabaseException.idl
+        storage/IDBDatabase.idl
+        storage/IDBFactory.idl
+        storage/IDBIndex.idl
+        storage/IDBKey.idl
+        storage/IDBKeyRange.idl
+        storage/IDBObjectStore.idl
+        storage/IDBRequest.idl
+        storage/IDBTransaction.idl
+    )
+ENDIF ()
+
+IF (ENABLE_DOM_STORAGE)
+    LIST(APPEND WebCore_IDL_FILES
+        storage/Storage.idl
+        storage/StorageEvent.idl
+    )
+ENDIF ()
+
 IF (ENABLE_LEVELDB)
     LIST(APPEND WebCore_SOURCES
         platform/leveldb/LevelDBDatabase.cpp
@@ -1569,6 +1571,16 @@
     )
 ENDIF ()
 
+IF (ENABLE_XPATH)
+    LIST(APPEND WebCore_IDL_FILES
+        xml/XPathEvaluator.idl
+        xml/XPathException.idl
+        xml/XPathExpression.idl
+        xml/XPathNSResolver.idl
+        xml/XPathResult.idl
+    )
+ENDIF ()
+
 IF (ENABLE_SVG)
     LIST(APPEND WebCore_SOURCES
         bindings/js/JSSVGElementInstanceCustom.cpp
@@ -1939,6 +1951,13 @@
     )
 ENDIF()
 
+IF (ENABLE_WEB_SOCKETS)
+    LIST(APPEND WebCore_IDL_FILES
+        websockets/CloseEvent.idl
+        websockets/WebSocket.idl
+    )
+ENDIF ()
+
 IF (ENABLE_VIDEO_TRACK)
     LIST(APPEND WebCore_SOURCES
         html/HTMLTrackElement.cpp
@@ -2054,6 +2073,12 @@
     )
 ENDIF ()
 
+IF (ENABLE_OFFLINE_WEB_APPLICATIONS)
+    LIST(APPEND WebCore_IDL_FILES
+        loader/appcache/DOMApplicationCache.idl
+    )
+ENDIF ()
+
 # Modules that the bindings generator scripts may use
 SET(SCRIPTS_BINDINGS
     ${WEBCORE_DIR}/bindings/scripts/IDLParser.pm

Modified: trunk/Source/WebCore/ChangeLog (88715 => 88716)


--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:32:47 UTC (rev 88715)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:36:45 UTC (rev 88716)
@@ -1,3 +1,21 @@
+2011-06-13  Lucas De Marchi  <[email protected]>
+
+        Reviewed by Eric Seidel.
+
+        [CMAKE] Conditionally generate DerivedSources
+        https://bugs.webkit.org/show_bug.cgi?id=62277
+
+        Speedup build by not generating DerivedSources of features that are
+        disabled. This was already been done for some features like ENABLE_SVG
+        and now it's extended the following features: ENABLE_DATABASE,
+        ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
+        ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
+        ENABLE_DATA_TRANSFER_ITEMS.
+
+        No change in functionality so no new tests.
+
+        * CMakeLists.txt: move .idl files to be conditionally generated.
+
 2011-06-13  Leandro Pereira  <[email protected]>
 
         Reviewed by Eric Seidel.

Modified: trunk/Source/cmakeconfig.h.cmake (88715 => 88716)


--- trunk/Source/cmakeconfig.h.cmake	2011-06-13 22:32:47 UTC (rev 88715)
+++ trunk/Source/cmakeconfig.h.cmake	2011-06-13 22:36:45 UTC (rev 88716)
@@ -20,6 +20,7 @@
 #cmakedefine01 ENABLE_GEOLOCATION
 #cmakedefine01 ENABLE_GLIB_SUPPORT
 #cmakedefine01 ENABLE_ICONDATABASE
+#cmakedefine01 ENABLE_INDEXED_DATABASE
 #cmakedefine01 ENABLE_INSPECTOR
 #cmakedefine01 ENABLE_JAVASCRIPT_DEBUGGER
 #cmakedefine01 ENABLE_JIT
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to