[webkit-changes] [88805] trunk/Source/WebCore

Tue, 14 Jun 2011 08:49:34 -0700

Title: [88805] trunk/Source/WebCore
Revision
88805
Author
[email protected]
Date
2011-06-14 08:48:47 -0700 (Tue, 14 Jun 2011)

Log Message

2011-06-14  Luke Macpherson   <[email protected]>

        Reviewed by Eric Seidel.

        Implement CSS border radius properies in CSSStyleApplyProperty
        https://bugs.webkit.org/show_bug.cgi?id=62265

        No new tests / refactoring only.

        * css/CSSStyleApplyProperty.cpp:
        Implement new class to culculate border radius, initialize for appropriate properties.
        (WebCore::ApplyPropertyBorderRadius::ApplyPropertyBorderRadius):
        (WebCore::ApplyPropertyBorderRadius::applyValue):
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        * css/CSSStyleSelector.cpp:
        Remove old implementations.
        (WebCore::CSSStyleSelector::applyProperty):
        * page/animation/AnimationBase.cpp:
        Pass LengthSize by value.
        (WebCore::AnimationBase::ensurePropertyMap):
        * rendering/style/RenderStyle.h:
        Pass LengthSize by value consistently.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (88804 => 88805)


--- trunk/Source/WebCore/ChangeLog	2011-06-14 15:46:24 UTC (rev 88804)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 15:48:47 UTC (rev 88805)
@@ -159,6 +159,29 @@
 
         Reviewed by Yury Semikhatsky.
 
+        Web Inspector: use ew-resize instead of col-resize for non-columns.
+        https://bugs.webkit.org/show_bug.cgi?id=62640
+
+        * inspector/front-end/ElementsPanel.js:
+        (WebInspector.ElementsPanel.prototype.rightSidebarResizerDragStart):
+        * inspector/front-end/Panel.js:
+        (WebInspector.Panel.prototype._startSidebarDragging):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
+        * inspector/front-end/TimelineOverviewPane.js:
+        (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
+        (WebInspector.TimelineOverviewPane.prototype._dragWindow):
+        * inspector/front-end/inspector.css:
+        (body.attached #toolbar):
+        (body.drawer-visible #main-status-bar):
+        (#scripts-sidebar-resizer-widget):
+        (.sidebar-resizer-vertical):
+        (.timeline-window-resizer):
+
+2011-06-14  Pavel Feldman  <[email protected]>
+
+        Reviewed by Yury Semikhatsky.
+
         Web Inspector: reload from within inspector window does not work while debugger is paused.
         https://bugs.webkit.org/show_bug.cgi?id=62631

Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (88804 => 88805)


--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-06-14 15:46:24 UTC (rev 88804)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-06-14 15:48:47 UTC (rev 88805)
@@ -1098,7 +1098,7 @@
 
     rightSidebarResizerDragStart: function(event)
     {
-        WebInspector.elementDragStart(this.sidebarElement, this.rightSidebarResizerDrag.bind(this), this.rightSidebarResizerDragEnd.bind(this), event, "col-resize");
+        WebInspector.elementDragStart(this.sidebarElement, this.rightSidebarResizerDrag.bind(this), this.rightSidebarResizerDragEnd.bind(this), event, "ew-resize");
     },
 
     rightSidebarResizerDragEnd: function(event)

Modified: trunk/Source/WebCore/inspector/front-end/Panel.js (88804 => 88805)


--- trunk/Source/WebCore/inspector/front-end/Panel.js	2011-06-14 15:46:24 UTC (rev 88804)
+++ trunk/Source/WebCore/inspector/front-end/Panel.js	2011-06-14 15:48:47 UTC (rev 88805)
@@ -316,7 +316,7 @@
 
     _startSidebarDragging: function(event)
     {
-        WebInspector.elementDragStart(this.sidebarResizeElement, this._sidebarDragging.bind(this), this._endSidebarDragging.bind(this), event, "col-resize");
+        WebInspector.elementDragStart(this.sidebarResizeElement, this._sidebarDragging.bind(this), this._endSidebarDragging.bind(this), event, "ew-resize");
     },
 
     _sidebarDragging: function(event)

Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (88804 => 88805)


--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2011-06-14 15:46:24 UTC (rev 88804)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js	2011-06-14 15:48:47 UTC (rev 88805)
@@ -665,7 +665,7 @@
 
     _startSidebarResizeDrag: function(event)
     {
-        WebInspector.elementDragStart(this.sidebarElement, this._sidebarResizeDrag.bind(this), this._endSidebarResizeDrag.bind(this), event, "col-resize");
+        WebInspector.elementDragStart(this.sidebarElement, this._sidebarResizeDrag.bind(this), this._endSidebarResizeDrag.bind(this), event, "ew-resize");
 
         if (event.target === this.sidebarResizeWidgetElement)
             this._dragOffset = (event.target.offsetWidth - (event.pageX - event.target.totalOffsetLeft));

Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (88804 => 88805)


--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2011-06-14 15:46:24 UTC (rev 88804)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js	2011-06-14 15:48:47 UTC (rev 88805)
@@ -221,7 +221,7 @@
 
     _resizeWindow: function(resizeElement, event)
     {
-        WebInspector.elementDragStart(resizeElement, this._windowResizeDragging.bind(this, resizeElement), this._endWindowDragging.bind(this), event, "col-resize");
+        WebInspector.elementDragStart(resizeElement, this._windowResizeDragging.bind(this, resizeElement), this._endWindowDragging.bind(this), event, "ew-resize");
     },
 
     _windowResizeDragging: function(resizeElement, event)
@@ -244,7 +244,7 @@
             } else if (node === this._overviewGrid.element) {
                 var position = event.pageX - this._overviewGrid.element.offsetLeft;
                 this._overviewWindowSelector = new WebInspector.TimelinePanel.WindowSelector(this._overviewGrid.element, position, event);
-                WebInspector.elementDragStart(null, this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), event, "col-resize");
+                WebInspector.elementDragStart(null, this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), event, "ew-resize");
                 break;
             } else if (node === this._leftResizeElement || node === this._rightResizeElement) {
                 this._resizeWindow(node, event);

Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (88804 => 88805)


--- trunk/Source/WebCore/inspector/front-end/inspector.css	2011-06-14 15:46:24 UTC (rev 88804)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css	2011-06-14 15:48:47 UTC (rev 88805)
@@ -97,7 +97,7 @@
 body.attached #toolbar {
     height: 34px;
     border-top: 1px solid rgb(100, 100, 100);
-    cursor: row-resize;
+    cursor: ns-resize;
     padding-left: 0;
 }
 
@@ -445,7 +445,7 @@
     background-image: url(Images/statusbarResizerVertical.png), url(Images/statusbarBackground.png);
     background-repeat: no-repeat, repeat-x;
     background-position: right center, center;
-    cursor: row-resize;
+    cursor: ns-resize;
 }
 
 body.drawer-visible #main-status-bar * {
@@ -2687,7 +2687,7 @@
     bottom: 0;
     right: 225px;
     width: 16px;
-    cursor: col-resize;
+    cursor: ew-resize;
     background-image: url(Images/statusbarResizerHorizontal.png);
     background-repeat: no-repeat;
     background-position: center;
@@ -3220,7 +3220,7 @@
     bottom: 0;
     width: 5px;
     z-index: 500;
-    cursor: col-resize;
+    cursor: ew-resize;
 }
 
 .resources .sidebar-resizer-vertical {
@@ -3728,7 +3728,7 @@
     margin-right: -2px;
     background-color: rgb(153, 153, 153);
     z-index: 500;
-    cursor: col-resize;
+    cursor: ew-resize;
     -webkit-border-radius: 2px;
     -webkit-box-shadow: white 1px 0 0, white -1px 0 0, white 0 1px 0, white 0 -1px 0;
 }

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to