Title: [88907] trunk/Source/WebKit2
- Revision
- 88907
- Author
- [email protected]
- Date
- 2011-06-14 23:13:05 -0700 (Tue, 14 Jun 2011)
Log Message
2011-06-14 Eunmi Lee <[email protected]>
Reviewed by Sam Weinig.
[EFL][WK2] Change string operation to makeString()
https://bugs.webkit.org/show_bug.cgi?id=62527
Use makeString() because it is better than creating individual strings and concatenating them.
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (88906 => 88907)
--- trunk/Source/WebKit2/ChangeLog 2011-06-15 05:29:08 UTC (rev 88906)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-15 06:13:05 UTC (rev 88907)
@@ -1,3 +1,15 @@
+2011-06-14 Eunmi Lee <[email protected]>
+
+ Reviewed by Sam Weinig.
+
+ [EFL][WK2] Change string operation to makeString()
+ https://bugs.webkit.org/show_bug.cgi?id=62527
+
+ Use makeString() because it is better than creating individual strings and concatenating them.
+
+ * UIProcess/efl/WebPageProxyEfl.cpp:
+ (WebKit::WebPageProxy::standardUserAgent):
+
2011-06-14 Sam Weinig <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp (88906 => 88907)
--- trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp 2011-06-15 05:29:08 UTC (rev 88906)
+++ trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp 2011-06-15 06:13:05 UTC (rev 88907)
@@ -30,6 +30,7 @@
#include "PageClientImpl.h"
#include <sys/utsname.h>
+#include <wtf/text/StringConcatenate.h>
namespace WebKit {
@@ -40,9 +41,9 @@
String WebPageProxy::standardUserAgent(const String& applicationNameForUserAgent)
{
- WTF::String platform;
- WTF::String version;
- WTF::String osVersion;
+ String platform;
+ String version;
+ String osVersion;
#if PLATFORM(X11)
platform = "X11";
@@ -53,7 +54,7 @@
String::number(WEBKIT_USER_AGENT_MINOR_VERSION), '+');
struct utsname name;
if (uname(&name) != -1)
- osVersion = WTF::String(name.sysname) + " " + WTF::String(name.machine);
+ osVersion = makeString(name.sysname, ' ', name.machine);
else
osVersion = "Unknown";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
