Title: [88920] trunk
- Revision
- 88920
- Author
- [email protected]
- Date
- 2011-06-15 05:09:18 -0700 (Wed, 15 Jun 2011)
Log Message
2011-06-14 Alexander Pavlov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: "data" URLs not detected in CSS url(...) values properly
https://bugs.webkit.org/show_bug.cgi?id=62643
WebCore:
* inspector/front-end/inspector.js:
(WebInspector.completeURL):
LayoutTests:
* inspector/styles/styles-url-linkify-expected.txt:
* inspector/styles/styles-url-linkify.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (88919 => 88920)
--- trunk/LayoutTests/ChangeLog 2011-06-15 11:46:24 UTC (rev 88919)
+++ trunk/LayoutTests/ChangeLog 2011-06-15 12:09:18 UTC (rev 88920)
@@ -1,3 +1,13 @@
+2011-06-14 Alexander Pavlov <[email protected]>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: "data" URLs not detected in CSS url(...) values properly
+ https://bugs.webkit.org/show_bug.cgi?id=62643
+
+ * inspector/styles/styles-url-linkify-expected.txt:
+ * inspector/styles/styles-url-linkify.html:
+
2011-06-15 Mario Sanchez Prada <[email protected]>
Unreviewed, skipped accessibility test failing in GTK.
Modified: trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt (88919 => 88920)
--- trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt 2011-06-15 11:46:24 UTC (rev 88919)
+++ trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt 2011-06-15 12:09:18 UTC (rev 88920)
@@ -1,7 +1,7 @@
-Tests that URLs are linked to and completed correctly. Bugs 51663, 53171
+Tests that URLs are linked to and completed correctly. Bugs 51663, 53171, 62643
-Partial URLs completed:
+URLs completed:
http://example.com/
http://example.com/moo
https://secure.com/moo
@@ -12,6 +12,7 @@
http://example.com/moo
http://example.com/foo?a=b
http://example.com/foo?a=b
+data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEIAAABCAgMAAACeOuh7AAAABGdBTUEAAK/INwWK6QAAAAlQTFRF////AAAA////fu+PTwAAAAF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8AAAAASUVORK5CYII=
Link for a URI from CSS document:
inspector/styles/resources/fromcss.png
Link for a URI from iframe inline stylesheet:
Modified: trunk/LayoutTests/inspector/styles/styles-url-linkify.html (88919 => 88920)
--- trunk/LayoutTests/inspector/styles/styles-url-linkify.html 2011-06-15 11:46:24 UTC (rev 88919)
+++ trunk/LayoutTests/inspector/styles/styles-url-linkify.html 2011-06-15 12:09:18 UTC (rev 88920)
@@ -13,7 +13,7 @@
InspectorTest.addResult(WebInspector.completeURL(baseURL, href));
}
- InspectorTest.addResult("Partial URLs completed:");
+ InspectorTest.addResult("URLs completed:");
completeURL("http://example.com", "/");
completeURL("http://example.com", "moo");
completeURL("http://example.com/", "https://secure.com/moo");
@@ -25,6 +25,9 @@
completeURL("http://example.com/foo", "?a=b");
completeURL("http://example.com/foo?c=d", "?a=b");
+ const dataURL = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEIAAABCAgMAAACeOuh7AAAABGdBTUEAAK/INwWK6QAAAAlQTFRF////AAAA////fu+PTwAAAAF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8AAAAASUVORK5CYII=";
+ completeURL("https://example.com/foo", dataURL);
+
function dumpHref()
{
var href;
@@ -70,7 +73,7 @@
</head>
<body _onload_="runAfterIframeIsLoaded()">
<p>
-Tests that URLs are linked to and completed correctly. Bugs <a href="" <a href=""
+Tests that URLs are linked to and completed correctly. Bugs <a href="" <a href="" <a href=""
</p>
<div id="local"></div>
<iframe src=""
Modified: trunk/Source/WebCore/ChangeLog (88919 => 88920)
--- trunk/Source/WebCore/ChangeLog 2011-06-15 11:46:24 UTC (rev 88919)
+++ trunk/Source/WebCore/ChangeLog 2011-06-15 12:09:18 UTC (rev 88920)
@@ -1,3 +1,13 @@
+2011-06-14 Alexander Pavlov <[email protected]>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: "data" URLs not detected in CSS url(...) values properly
+ https://bugs.webkit.org/show_bug.cgi?id=62643
+
+ * inspector/front-end/inspector.js:
+ (WebInspector.completeURL):
+
2011-06-15 Pavel Feldman <[email protected]>
Reviewed by Yury Semikhatsky.
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (88919 => 88920)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-06-15 11:46:24 UTC (rev 88919)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-06-15 12:09:18 UTC (rev 88920)
@@ -1318,7 +1318,7 @@
if (href) {
// Return absolute URLs as-is.
var parsedHref = href.asParsedURL();
- if (parsedHref && parsedHref.scheme)
+ if ((parsedHref && parsedHref.scheme) || href.indexOf("data:") === 0)
return href;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
