Title: [88928] trunk/Source/WebKit/efl
- Revision
- 88928
- Author
- [email protected]
- Date
- 2011-06-15 07:38:14 -0700 (Wed, 15 Jun 2011)
Log Message
2011-06-15 Sheriff Bot <[email protected]>
Unreviewed, rolling out r88723.
http://trac.webkit.org/changeset/88723
https://bugs.webkit.org/show_bug.cgi?id=62726
Stack can be empty, so it needs to be checked before as
pointed out in the comments of the bug. (Requested by demarchi
on #webkit).
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::registerCommandForUndo):
(WebCore::EditorClientEfl::registerCommandForRedo):
(WebCore::EditorClientEfl::clearUndoRedoOperations):
(WebCore::EditorClientEfl::canRedo):
(WebCore::EditorClientEfl::redo):
* WebCoreSupport/EditorClientEfl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (88927 => 88928)
--- trunk/Source/WebKit/efl/ChangeLog 2011-06-15 14:30:22 UTC (rev 88927)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-06-15 14:38:14 UTC (rev 88928)
@@ -1,3 +1,21 @@
+2011-06-15 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r88723.
+ http://trac.webkit.org/changeset/88723
+ https://bugs.webkit.org/show_bug.cgi?id=62726
+
+ Stack can be empty, so it needs to be checked before as
+ pointed out in the comments of the bug. (Requested by demarchi
+ on #webkit).
+
+ * WebCoreSupport/EditorClientEfl.cpp:
+ (WebCore::EditorClientEfl::registerCommandForUndo):
+ (WebCore::EditorClientEfl::registerCommandForRedo):
+ (WebCore::EditorClientEfl::clearUndoRedoOperations):
+ (WebCore::EditorClientEfl::canRedo):
+ (WebCore::EditorClientEfl::redo):
+ * WebCoreSupport/EditorClientEfl.h:
+
2011-06-13 Michal Pakula vel Rutka <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (88927 => 88928)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2011-06-15 14:30:22 UTC (rev 88927)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2011-06-15 14:38:14 UTC (rev 88928)
@@ -147,19 +147,17 @@
void EditorClientEfl::registerCommandForUndo(WTF::PassRefPtr<EditCommand> command)
{
- redoStack.clear();
undoStack.append(command);
}
-void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr<EditCommand> command)
+void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr<EditCommand>)
{
- redoStack.append(command);
+ notImplemented();
}
void EditorClientEfl::clearUndoRedoOperations()
{
undoStack.clear();
- redoStack.clear();
}
bool EditorClientEfl::canCopyCut(Frame*, bool defaultValue) const
@@ -179,7 +177,8 @@
bool EditorClientEfl::canRedo() const
{
- return !redoStack.isEmpty();
+ notImplemented();
+ return false;
}
void EditorClientEfl::undo()
@@ -191,9 +190,7 @@
void EditorClientEfl::redo()
{
- RefPtr<WebCore::EditCommand> command(*(--redoStack.end()));
- redoStack.remove(--redoStack.end());
- command->reapply();
+ notImplemented();
}
bool EditorClientEfl::shouldInsertNode(Node*, Range*, EditorInsertAction)
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (88927 => 88928)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2011-06-15 14:30:22 UTC (rev 88927)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2011-06-15 14:38:14 UTC (rev 88928)
@@ -47,7 +47,6 @@
class EditorClientEfl : public EditorClient, public TextCheckerClient {
protected:
WTF::Deque<WTF::RefPtr<WebCore::EditCommand> > undoStack;
- WTF::Deque<WTF::RefPtr<WebCore::EditCommand> > redoStack;
public:
EditorClientEfl(Evas_Object *view);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
