Title: [88977] trunk/Source/WebCore
- Revision
- 88977
- Author
- [email protected]
- Date
- 2011-06-15 15:11:50 -0700 (Wed, 15 Jun 2011)
Log Message
2011-06-15 Dimitri Glazkov <[email protected]>
Reviewed by Adam Barth.
Clarify FileChooser creation code.
https://bugs.webkit.org/show_bug.cgi?id=62756
initialize() method is only used once and that is not obvious, so just fold it into the create method.
Refactoring, no change in behavior.
* platform/FileChooser.cpp:
(WebCore::FileChooser::create): Folded initialize() code there.
* platform/FileChooser.h: Removed decl.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88976 => 88977)
--- trunk/Source/WebCore/ChangeLog 2011-06-15 22:02:50 UTC (rev 88976)
+++ trunk/Source/WebCore/ChangeLog 2011-06-15 22:11:50 UTC (rev 88977)
@@ -1,3 +1,18 @@
+2011-06-15 Dimitri Glazkov <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ Clarify FileChooser creation code.
+ https://bugs.webkit.org/show_bug.cgi?id=62756
+
+ initialize() method is only used once and that is not obvious, so just fold it into the create method.
+
+ Refactoring, no change in behavior.
+
+ * platform/FileChooser.cpp:
+ (WebCore::FileChooser::create): Folded initialize() code there.
+ * platform/FileChooser.h: Removed decl.
+
2011-06-15 Eric Carlson <[email protected]>
Reviewed by Alexey Proskuryakov.
Modified: trunk/Source/WebCore/platform/FileChooser.cpp (88976 => 88977)
--- trunk/Source/WebCore/platform/FileChooser.cpp 2011-06-15 22:02:50 UTC (rev 88976)
+++ trunk/Source/WebCore/platform/FileChooser.cpp 2011-06-15 22:11:50 UTC (rev 88977)
@@ -44,16 +44,11 @@
m_filenames = initialFilenames;
}
-void FileChooser::initialize()
-{
- loadIcon();
- m_isInitializing = false;
-}
-
PassRefPtr<FileChooser> FileChooser::create(FileChooserClient* client, const Vector<String>& initialFilenames)
{
RefPtr<FileChooser> chooser(adoptRef(new FileChooser(client, initialFilenames)));
- chooser->initialize();
+ chooser->loadIcon();
+ chooser->m_isInitializing = false;
return chooser;
}
Modified: trunk/Source/WebCore/platform/FileChooser.h (88976 => 88977)
--- trunk/Source/WebCore/platform/FileChooser.h 2011-06-15 22:02:50 UTC (rev 88976)
+++ trunk/Source/WebCore/platform/FileChooser.h 2011-06-15 22:11:50 UTC (rev 88977)
@@ -81,7 +81,6 @@
private:
FileChooser(FileChooserClient*, const Vector<String>& initialFilenames);
- void initialize();
void loadIcon();
FileChooserClient* m_client;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
