Title: [89005] trunk/Source/WebCore
- Revision
- 89005
- Author
- [email protected]
- Date
- 2011-06-15 21:40:01 -0700 (Wed, 15 Jun 2011)
Log Message
2011-06-15 Adam Barth <[email protected]>
Unreviewed. (Technically I should get this reviewed, but I
accidentally committed part of this patch in my previous commit,
causing a build break.)
Remove ScriptController::m_processingTimerCallback
https://bugs.webkit.org/show_bug.cgi?id=62776
This variable is unused. (It used to be used in a user gesture detection hack.)
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
* bindings/js/ScriptController.h:
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
* bindings/v8/ScriptController.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89004 => 89005)
--- trunk/Source/WebCore/ChangeLog 2011-06-16 04:38:26 UTC (rev 89004)
+++ trunk/Source/WebCore/ChangeLog 2011-06-16 04:40:01 UTC (rev 89005)
@@ -1,3 +1,23 @@
+2011-06-15 Adam Barth <[email protected]>
+
+ Unreviewed. (Technically I should get this reviewed, but I
+ accidentally committed part of this patch in my previous commit,
+ causing a build break.)
+
+ Remove ScriptController::m_processingTimerCallback
+ https://bugs.webkit.org/show_bug.cgi?id=62776
+
+ This variable is unused. (It used to be used in a user gesture detection hack.)
+
+ * bindings/js/ScheduledAction.cpp:
+ (WebCore::ScheduledAction::execute):
+ * bindings/js/ScriptController.cpp:
+ (WebCore::ScriptController::ScriptController):
+ * bindings/js/ScriptController.h:
+ * bindings/v8/ScriptController.cpp:
+ (WebCore::ScriptController::ScriptController):
+ * bindings/v8/ScriptController.h:
+
2011-06-15 Kent Tamura <[email protected]>
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebCore/bindings/js/ScheduledAction.cpp (89004 => 89005)
--- trunk/Source/WebCore/bindings/js/ScheduledAction.cpp 2011-06-16 04:38:26 UTC (rev 89004)
+++ trunk/Source/WebCore/bindings/js/ScheduledAction.cpp 2011-06-16 04:40:01 UTC (rev 89005)
@@ -126,15 +126,11 @@
if (!frame || !frame->script()->canExecuteScripts(AboutToExecuteScript))
return;
- frame->script()->setProcessingTimerCallback(true);
-
if (m_function) {
executeFunctionInContext(window, window->shell(), document);
Document::updateStyleForAllDocuments();
} else
frame->script()->executeScriptInWorld(m_isolatedWorld.get(), m_code);
-
- frame->script()->setProcessingTimerCallback(false);
}
#if ENABLE(WORKERS)
Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (89004 => 89005)
--- trunk/Source/WebCore/bindings/js/ScriptController.cpp 2011-06-16 04:38:26 UTC (rev 89004)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp 2011-06-16 04:40:01 UTC (rev 89005)
@@ -63,7 +63,6 @@
: m_frame(frame)
, m_sourceURL(0)
, m_inExecuteScript(false)
- , m_processingTimerCallback(false)
, m_paused(false)
#if ENABLE(NETSCAPE_PLUGIN_API)
, m_windowScriptNPObject(0)
Modified: trunk/Source/WebCore/bindings/js/ScriptController.h (89004 => 89005)
--- trunk/Source/WebCore/bindings/js/ScriptController.h 2011-06-16 04:38:26 UTC (rev 89004)
+++ trunk/Source/WebCore/bindings/js/ScriptController.h 2011-06-16 04:40:01 UTC (rev 89005)
@@ -108,7 +108,6 @@
void disableEval();
- void setProcessingTimerCallback(bool b) { m_processingTimerCallback = b; }
static bool processingUserGesture();
static bool canAccessFromCurrentOrigin(Frame*);
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (89004 => 89005)
--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2011-06-16 04:38:26 UTC (rev 89004)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2011-06-16 04:40:01 UTC (rev 89005)
@@ -109,7 +109,6 @@
: m_frame(frame)
, m_sourceURL(0)
, m_inExecuteScript(false)
- , m_processingTimerCallback(false)
, m_paused(false)
, m_proxy(adoptPtr(new V8Proxy(frame)))
#if ENABLE(NETSCAPE_PLUGIN_API)
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (89004 => 89005)
--- trunk/Source/WebCore/bindings/v8/ScriptController.h 2011-06-16 04:38:26 UTC (rev 89004)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h 2011-06-16 04:40:01 UTC (rev 89005)
@@ -157,7 +157,6 @@
TextPosition0 eventHandlerPosition() const;
- void setProcessingTimerCallback(bool processingTimerCallback) { m_processingTimerCallback = processingTimerCallback; }
static bool processingUserGesture();
void setPaused(bool paused) { m_paused = paused; }
@@ -195,7 +194,6 @@
bool m_inExecuteScript;
- bool m_processingTimerCallback;
bool m_paused;
OwnPtr<V8Proxy> m_proxy;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
