Title: [89149] trunk/LayoutTests
Revision
89149
Author
[email protected]
Date
2011-06-17 11:20:23 -0700 (Fri, 17 Jun 2011)

Log Message

2011-06-17  Annie Sullivan  <[email protected]>

        Reviewed by Ryosuke Niwa.

        Layout tests editing/inserting/return-key-in-hidden-field.html and return-key-span-start.html don't run in webkit2
        https://bugs.webkit.org/show_bug.cgi?id=62734

        Modify tests to use execCommand(insertParagraph) instead of eventSender to inject a new line.

        * editing/inserting/return-key-in-hidden-field-expected.txt:
        * editing/inserting/return-key-in-hidden-field.html:
        * editing/inserting/return-key-span-start.html:
        * platform/mac-wk2/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (89148 => 89149)


--- trunk/LayoutTests/ChangeLog	2011-06-17 18:19:32 UTC (rev 89148)
+++ trunk/LayoutTests/ChangeLog	2011-06-17 18:20:23 UTC (rev 89149)
@@ -2,6 +2,20 @@
 
         Reviewed by Ryosuke Niwa.
 
+        Layout tests editing/inserting/return-key-in-hidden-field.html and return-key-span-start.html don't run in webkit2
+        https://bugs.webkit.org/show_bug.cgi?id=62734
+
+        Modify tests to use execCommand(insertParagraph) instead of eventSender to inject a new line.
+
+        * editing/inserting/return-key-in-hidden-field-expected.txt:
+        * editing/inserting/return-key-in-hidden-field.html:
+        * editing/inserting/return-key-span-start.html:
+        * platform/mac-wk2/Skipped:
+
+2011-06-17  Annie Sullivan  <[email protected]>
+
+        Reviewed by Ryosuke Niwa.
+
         div can be a child of span on InsertParagraph
         https://bugs.webkit.org/show_bug.cgi?id=62687
 

Modified: trunk/LayoutTests/editing/inserting/return-key-in-hidden-field-expected.txt (89148 => 89149)


--- trunk/LayoutTests/editing/inserting/return-key-in-hidden-field-expected.txt	2011-06-17 18:19:32 UTC (rev 89148)
+++ trunk/LayoutTests/editing/inserting/return-key-in-hidden-field-expected.txt	2011-06-17 18:20:23 UTC (rev 89149)
@@ -3,3 +3,4 @@
 
 
 
+

Modified: trunk/LayoutTests/editing/inserting/return-key-in-hidden-field.html (89148 => 89149)


--- trunk/LayoutTests/editing/inserting/return-key-in-hidden-field.html	2011-06-17 18:19:32 UTC (rev 89148)
+++ trunk/LayoutTests/editing/inserting/return-key-in-hidden-field.html	2011-06-17 18:20:23 UTC (rev 89149)
@@ -1,3 +1,5 @@
+<!DOCTYPE html>
+<html>
 <body>
 <p>This tests to make sure that inserting a line break in a hidden textarea doesn't crash.
 To repro manually, press enter or return in the textarea.  We pass if we don't crash.</p>
@@ -16,18 +18,19 @@
 {
     document.getElementById("textarea").focus();
 
-    if (!window.layoutTestController || !window.eventSender)
+    if (!window.layoutTestController)
         return;
     layoutTestController.dumpAsText();
-    eventSender.keyDown('\n');
+    document.execCommand('InsertParagraph', false, null);
 
     document.getElementById("d2").focus();
     document.getElementById("d2").style.visibility = "";
 
     layoutTestController.dumpAsText();
-    eventSender.keyDown('\n');
+    document.execCommand('InsertParagraph', false, null);
 }
 runTest();
 
 </script>
 </body>
+</html>

Modified: trunk/LayoutTests/editing/inserting/return-key-span-start.html (89148 => 89149)


--- trunk/LayoutTests/editing/inserting/return-key-span-start.html	2011-06-17 18:19:32 UTC (rev 89148)
+++ trunk/LayoutTests/editing/inserting/return-key-span-start.html	2011-06-17 18:20:23 UTC (rev 89149)
@@ -6,7 +6,7 @@
 <script>
 var sel = window.getSelection();
 sel.setPosition(document.getElementById("dupe"), 0);
-eventSender.keyDown("\n");
+document.execCommand('InsertParagraph', false, null)
 Markup.description("This sets the selection to the start of a span, and hits the enter key.\n"
     + "Expected behavior: when the span is split, its ID should not be duplicated. See bug 62621.");
 Markup.dump(root);

Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (89148 => 89149)


--- trunk/LayoutTests/platform/mac-wk2/Skipped	2011-06-17 18:19:32 UTC (rev 89148)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2011-06-17 18:20:23 UTC (rev 89149)
@@ -85,7 +85,6 @@
 editing/input/option-page-up-down.html
 editing/input/page-up-down-scrolls.html
 editing/input/scroll-viewport-page-up-down.html
-editing/inserting/return-key-in-hidden-field.html
 editing/inserting/typing-tab-designmode-forms.html
 editing/inserting/typing-tab-designmode.html
 editing/pasteboard/4944770-2.html
@@ -1781,7 +1780,6 @@
 fast/forms/focus-with-display-block.html
 fast/forms/ValidityState-valueMissing-002.html
 svg/custom/focus-event-handling-keyboard.xhtml
-editing/inserting/return-key-span-start.html
 
 # eventSender.contextClick() is unimplemented
 editing/spelling/spellcheck-input-search-crash.html
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to