Title: [89174] trunk/Tools
- Revision
- 89174
- Author
- [email protected]
- Date
- 2011-06-17 14:48:12 -0700 (Fri, 17 Jun 2011)
Log Message
2011-06-17 Tony Chang <[email protected]>
Reviewed by Dirk Pranke.
[chromium] force rebaseline-chromium-webkit-tests to use the chromium port
https://bugs.webkit.org/show_bug.cgi?id=62907
This fixes a bug where the ImageDiff on the user's machine doesn't
match the logic used on the Chromium buildbots. This has the downside
of requiring that the Chromium ImageDiff is built, but it turns out
that even with --tolerance 0, the CG ImageDiff will allow small pixel
differences through.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (89173 => 89174)
--- trunk/Tools/ChangeLog 2011-06-17 21:46:16 UTC (rev 89173)
+++ trunk/Tools/ChangeLog 2011-06-17 21:48:12 UTC (rev 89174)
@@ -1,3 +1,18 @@
+2011-06-17 Tony Chang <[email protected]>
+
+ Reviewed by Dirk Pranke.
+
+ [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
+ https://bugs.webkit.org/show_bug.cgi?id=62907
+
+ This fixes a bug where the ImageDiff on the user's machine doesn't
+ match the logic used on the Chromium buildbots. This has the downside
+ of requiring that the Chromium ImageDiff is built, but it turns out
+ that even with --tolerance 0, the CG ImageDiff will allow small pixel
+ differences through.
+
+ * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
+
2011-06-17 Brent Fulgham <[email protected]>
[WinCairo] Unreviewed build correction.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py (89173 => 89174)
--- trunk/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py 2011-06-17 21:46:16 UTC (rev 89173)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py 2011-06-17 21:48:12 UTC (rev 89174)
@@ -805,11 +805,11 @@
def get_host_port_object(options):
"""Return a port object for the platform we're running on."""
- # The only thing we really need on the host is a way to diff
- # text files and image files, which means we need to check that some
- # version of ImageDiff has been built. We will look for either Debug
- # or Release versions of the default port on the platform.
+ # We want the ImageDiff logic to match that of the chromium bots, so we
+ # force the use of a Chromium port. We will look for either Debug or
+ # Release versions.
options.configuration = "Release"
+ options.chromium = True
port_obj = port.get(None, options)
if not port_obj.check_image_diff(override_step=None, logging=False):
_log.debug('No release version of the image diff binary was found.')
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
