Diff
Modified: trunk/Source/WebCore/CMakeListsEfl.txt (89196 => 89197)
--- trunk/Source/WebCore/CMakeListsEfl.txt 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/CMakeListsEfl.txt 2011-06-18 19:43:47 UTC (rev 89197)
@@ -5,7 +5,6 @@
LIST(APPEND WebCore_INCLUDE_DIRECTORIES
"${_javascript_CORE_DIR}/wtf/gobject"
- "${_javascript_CORE_DIR}/wtf/text"
"${WEBCORE_DIR}/platform/efl"
"${WEBCORE_DIR}/platform/text/efl"
"${WEBCORE_DIR}/platform/graphics/efl"
Modified: trunk/Source/WebCore/CMakeListsWinCE.txt (89196 => 89197)
--- trunk/Source/WebCore/CMakeListsWinCE.txt 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/CMakeListsWinCE.txt 2011-06-18 19:43:47 UTC (rev 89197)
@@ -1,5 +1,4 @@
LIST(APPEND WebCore_INCLUDE_DIRECTORIES
- "${_javascript_CORE_DIR}/wtf/text"
"${WEBCORE_DIR}/platform/wince"
"${WEBCORE_DIR}/platform/win"
"${WEBCORE_DIR}/platform/text/wince"
Modified: trunk/Source/WebCore/ChangeLog (89196 => 89197)
--- trunk/Source/WebCore/ChangeLog 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/ChangeLog 2011-06-18 19:43:47 UTC (rev 89197)
@@ -1,3 +1,22 @@
+2011-06-18 Holger Hans Peter Freyther <[email protected]>
+
+ Reviewed by Brent Fulgham.
+
+ [misc] JSC/wtf/text/*.h should not be included via #include ""
+ https://bugs.webkit.org/show_bug.cgi?id=60836
+
+ Adam Barth pointed out that one should not include files from
+ _javascript_Core/wtf/text using #include "File.h". This change
+ is addressing it.
+
+ * CMakeListsEfl.txt: Remove _javascript_Core/wtf/text.
+ * CMakeListsWinCE.txt: Remove _javascript_Core/wtf/text.
+ * platform/graphics/freetype/FontCacheFreeType.cpp: Change CString.h include.
+ * platform/graphics/pango/FontCachePango.cpp: Change CString.h include.
+ * platform/graphics/wx/FontPlatformData.h: Change StringImpl.h include.
+ * platform/network/soup/ResourceHandleSoup.cpp: Change CString.h include.
+ * platform/network/soup/SocketStreamHandleSoup.cpp: Change CString.h include.
+
2011-06-18 Sam Weinig <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp (89196 => 89197)
--- trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp 2011-06-18 19:43:47 UTC (rev 89197)
@@ -22,7 +22,6 @@
#include "config.h"
#include "FontCache.h"
-#include "CString.h"
#include "Font.h"
#include "OwnPtrCairo.h"
#include "RefPtrCairo.h"
@@ -31,6 +30,7 @@
#include <cairo.h>
#include <fontconfig/fcfreetype.h>
#include <wtf/Assertions.h>
+#include <wtf/text/CString.h>
namespace WebCore {
Modified: trunk/Source/WebCore/platform/graphics/pango/FontCachePango.cpp (89196 => 89197)
--- trunk/Source/WebCore/platform/graphics/pango/FontCachePango.cpp 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/platform/graphics/pango/FontCachePango.cpp 2011-06-18 19:43:47 UTC (rev 89197)
@@ -21,11 +21,11 @@
#include "config.h"
#include "FontCache.h"
-#include "CString.h"
#include "Font.h"
#include "OwnPtrCairo.h"
#include "SimpleFontData.h"
#include <wtf/Assertions.h>
+#include <wtf/text/CString.h>
namespace WebCore {
Modified: trunk/Source/WebCore/platform/graphics/wx/FontPlatformData.h (89196 => 89197)
--- trunk/Source/WebCore/platform/graphics/wx/FontPlatformData.h 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/platform/graphics/wx/FontPlatformData.h 2011-06-18 19:43:47 UTC (rev 89197)
@@ -32,11 +32,11 @@
#include "FontDescription.h"
#include "FontWidthVariant.h"
#include "FontOrientation.h"
-#include "StringImpl.h"
#include <wtf/Forward.h>
#include <wtf/RefPtr.h>
#include <wtf/text/AtomicString.h>
#include <wtf/text/CString.h>
+#include <wtf/text/StringImpl.h>
#include <wx/defs.h>
#include <wx/font.h>
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (89196 => 89197)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-06-18 19:43:47 UTC (rev 89197)
@@ -28,7 +28,6 @@
#include "ResourceHandle.h"
#include "Base64.h"
-#include "CString.h"
#include "ChromeClient.h"
#include "CookieJarSoup.h"
#include "CachedResourceLoader.h"
@@ -57,6 +56,7 @@
#include <sys/stat.h>
#include <sys/types.h>
#include <unistd.h>
+#include <wtf/text/CString.h>
namespace WebCore {
Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (89196 => 89197)
--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp 2011-06-18 19:43:47 UTC (rev 89197)
@@ -31,7 +31,6 @@
#include "config.h"
#include "SocketStreamHandle.h"
-#include "CString.h"
#include "GOwnPtr.h"
#include "KURL.h"
#include "Logging.h"
@@ -42,6 +41,7 @@
#include "Vector.h"
#include <gio/gio.h>
#include <glib.h>
+#include <wtf/text/CString.h>
#define READ_BUFFER_SIZE 1024
Modified: trunk/Source/WebKit/wx/ChangeLog (89196 => 89197)
--- trunk/Source/WebKit/wx/ChangeLog 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebKit/wx/ChangeLog 2011-06-18 19:43:47 UTC (rev 89197)
@@ -1,3 +1,16 @@
+2011-06-18 Holger Hans Peter Freyther <[email protected]>
+
+ Reviewed by Brent Fulgham.
+
+ [misc] JSC/wtf/text/*.h should not be included via #include ""
+ https://bugs.webkit.org/show_bug.cgi?id=60836
+
+ Adam Barth pointed out that one should not include files from
+ _javascript_Core/wtf/text using #include "File.h". This change
+ is addressing it.
+
+ * WebEdit.cpp: Include file via <wtf/text/File.h>.
+
2011-06-12 Adam Barth <[email protected]>
Reviewed by Alexey Proskuryakov.
Modified: trunk/Source/WebKit/wx/WebEdit.cpp (89196 => 89197)
--- trunk/Source/WebKit/wx/WebEdit.cpp 2011-06-18 19:33:28 UTC (rev 89196)
+++ trunk/Source/WebKit/wx/WebEdit.cpp 2011-06-18 19:43:47 UTC (rev 89197)
@@ -8,11 +8,11 @@
#include "Frame.h"
#include "HTMLNames.h"
#include "QualifiedName.h"
-#include "StringImpl.h"
#include "WebFrame.h"
#include "WebDOMElement.h"
#include <wtf/text/AtomicString.h>
+#include <wtf/text/StringImpl.h>
namespace WebCore {
