Title: [89202] trunk/Tools
- Revision
- 89202
- Author
- [email protected]
- Date
- 2011-06-18 13:10:14 -0700 (Sat, 18 Jun 2011)
Log Message
2011-06-18 Evan Martin <[email protected]>
Reviewed by Darin Adler.
Compiler warning in double->int conversion in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=51554
This code is providing a JS API for removing a property by numeric ID.
We get it from JS as a double, and must convert it to an int before using it.
Test: LayoutTests/plugins/npruntime/remove-property.html
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
(NPRuntimeRemoveProperty::TestObject::invoke):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (89201 => 89202)
--- trunk/Tools/ChangeLog 2011-06-18 20:03:24 UTC (rev 89201)
+++ trunk/Tools/ChangeLog 2011-06-18 20:10:14 UTC (rev 89202)
@@ -1,3 +1,18 @@
+2011-06-18 Evan Martin <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ Compiler warning in double->int conversion in TestNetscapePlugIn
+ https://bugs.webkit.org/show_bug.cgi?id=51554
+
+ This code is providing a JS API for removing a property by numeric ID.
+ We get it from JS as a double, and must convert it to an int before using it.
+
+ Test: LayoutTests/plugins/npruntime/remove-property.html
+
+ * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
+ (NPRuntimeRemoveProperty::TestObject::invoke):
+
2011-06-18 Patrick Gansterer <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp (89201 => 89202)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp 2011-06-18 20:03:24 UTC (rev 89201)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp 2011-06-18 20:10:14 UTC (rev 89202)
@@ -63,7 +63,7 @@
propertyName = pluginTest()->NPN_GetStringIdentifier(propertyNameString.c_str());
} else {
- int32_t number = arguments[1].value.doubleValue;
+ int32_t number = static_cast<int32_t>(arguments[1].value.doubleValue);
propertyName = pluginTest()->NPN_GetIntIdentifier(number);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
