Diff
Modified: trunk/Tools/ChangeLog (89288 => 89289)
--- trunk/Tools/ChangeLog 2011-06-20 21:18:31 UTC (rev 89288)
+++ trunk/Tools/ChangeLog 2011-06-20 21:23:25 UTC (rev 89289)
@@ -1,3 +1,16 @@
+2011-06-20 Eric Seidel <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ commit-queue/ews-bots should run run-bindings-tests for every patch
+ https://bugs.webkit.org/show_bug.cgi?id=63010
+
+ * Scripts/webkitpy/common/config/ports.py:
+ * Scripts/webkitpy/tool/commands/download_unittest.py:
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ * Scripts/webkitpy/tool/steps/runtests_unittest.py:
+ * Scripts/webkitpy/tool/steps/steps_unittest.py:
+
2011-06-20 Chang Shu <[email protected]>
Reviewed by Adam Barth.
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (89288 => 89289)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-06-20 21:18:31 UTC (rev 89288)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-06-20 21:23:25 UTC (rev 89289)
@@ -118,6 +118,10 @@
return cls.script_shell_command("test-webkitperl")
@classmethod
+ def run_bindings_tests_command(cls):
+ return cls.script_shell_command("run-bindings-tests")
+
+ @classmethod
def layout_tests_results_path(cls):
return "/tmp/layout-test-results/results.html"
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (89288 => 89289)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-06-20 21:18:31 UTC (rev 89288)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-06-20 21:23:25 UTC (rev 89289)
@@ -89,7 +89,7 @@
self.assert_execute_outputs(Build(), [], options=self._default_options(), expected_stderr=expected_stderr)
def test_build_and_test(self):
- expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n"
+ expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n"
self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr)
def test_apply_attachment(self):
@@ -107,7 +107,7 @@
self.assert_execute_outputs(ApplyFromBug(), [42], options=options, expected_stderr=expected_stderr)
def test_land_diff(self):
- expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
+ expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
mock_tool = MockTool()
mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
mock_tool.checkout().modified_changelogs = Mock(return_value=[])
@@ -117,7 +117,7 @@
self.assertEqual(mock_tool.checkout().modified_changelogs.call_count, 1)
def test_land_red_builders(self):
- expected_stderr = '\nWARNING: Builders ["Builder2"] are red, please watch your commit carefully.\nSee http://dummy_buildbot_host/console?category=core\n\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n'
+ expected_stderr = '\nWARNING: Builders ["Builder2"] are red, please watch your commit carefully.\nSee http://dummy_buildbot_host/console?category=core\n\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n'
mock_tool = MockTool()
mock_tool.buildbot.light_tree_on_fire()
self.assert_execute_outputs(Land(), [42], options=self._default_options(), expected_stderr=expected_stderr, tool=mock_tool)
@@ -143,6 +143,7 @@
Building WebKit
Running Python unit tests
Running Perl unit tests
+Running Bindings tests
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -159,6 +160,7 @@
Building WebKit
Running Python unit tests
Running Perl unit tests
+Running Bindings tests
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -168,6 +170,7 @@
Building WebKit
Running Python unit tests
Running Perl unit tests
+Running Bindings tests
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (89288 => 89289)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2011-06-20 21:18:31 UTC (rev 89288)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2011-06-20 21:23:25 UTC (rev 89289)
@@ -56,6 +56,11 @@
log("Running Perl unit tests")
self._tool.executive.run_and_throw_if_fail(perl_unittests_command)
+ bindings_tests_command = self._tool.port().run_bindings_tests_command()
+ if bindings_tests_command:
+ log("Running Bindings tests")
+ self._tool.executive.run_and_throw_if_fail(bindings_tests_command)
+
_javascript_core_tests_command = self._tool.port().run_javascriptcore_tests_command()
if _javascript_core_tests_command:
log("Running _javascript_Core tests")
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py (89288 => 89289)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2011-06-20 21:18:31 UTC (rev 89288)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2011-06-20 21:23:25 UTC (rev 89289)
@@ -38,7 +38,8 @@
tool._port.run_python_unittests_command = lambda: None
tool._port.run_perl_unittests_command = lambda: None
step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False))
- expected_stderr = """Running _javascript_Core tests
+ expected_stderr = """Running Bindings tests
+Running _javascript_Core tests
Running run-webkit-tests
"""
OutputCapture().assert_outputs(self, step.run, [{}], expected_stderr=expected_stderr)
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py (89288 => 89289)
--- trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2011-06-20 21:18:31 UTC (rev 89288)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2011-06-20 21:23:25 UTC (rev 89289)
@@ -79,6 +79,8 @@
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitpy']
Running Perl unit tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl']
+Running Bindings tests
+MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests']
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-_javascript_core-tests']
Running run-webkit-tests
