Title: [89332] trunk
- Revision
- 89332
- Author
- [email protected]
- Date
- 2011-06-20 20:00:16 -0700 (Mon, 20 Jun 2011)
Log Message
2011-06-20 Dai Mikurube <[email protected]>
Reviewed by Kent Tamura.
Webkit allows disabled option as value of "required" select
https://bugs.webkit.org/show_bug.cgi?id=62668
* fast/forms/ValidityState-valueMissing-001-expected.txt:
* fast/forms/ValidityState-valueMissing-001.html: Changed to generate form validation error for disabled placeholder label option.
2011-06-20 Dai Mikurube <[email protected]>
Reviewed by Kent Tamura.
Webkit allows disabled option as value of "required" select
https://bugs.webkit.org/show_bug.cgi?id=62668
* html/HTMLSelectElement.cpp: Removed "disabled" checking due to spec change.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (89331 => 89332)
--- trunk/LayoutTests/ChangeLog 2011-06-21 02:58:22 UTC (rev 89331)
+++ trunk/LayoutTests/ChangeLog 2011-06-21 03:00:16 UTC (rev 89332)
@@ -1,3 +1,13 @@
+2011-06-20 Dai Mikurube <[email protected]>
+
+ Reviewed by Kent Tamura.
+
+ Webkit allows disabled option as value of "required" select
+ https://bugs.webkit.org/show_bug.cgi?id=62668
+
+ * fast/forms/ValidityState-valueMissing-001-expected.txt:
+ * fast/forms/ValidityState-valueMissing-001.html: Changed to generate form validation error for disabled placeholder label option.
+
2011-06-20 Kent Tamura <[email protected]>
[Chromium] text expectation update for r89116.
Modified: trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001-expected.txt (89331 => 89332)
--- trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001-expected.txt 2011-06-21 02:58:22 UTC (rev 89331)
+++ trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001-expected.txt 2011-06-21 03:00:16 UTC (rev 89332)
@@ -17,7 +17,7 @@
PASS valueMissingFor("select-fake-placeholder-selected-size2-multiple") is false
PASS valueMissingFor("select-without-fake-placeholder-size2-multiple") is false
PASS valueMissingFor("select-optgroup") is false
-PASS valueMissingFor("select-disabled-option") is false
+PASS valueMissingFor("select-disabled-option") is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001.html (89331 => 89332)
--- trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001.html 2011-06-21 02:58:22 UTC (rev 89331)
+++ trunk/LayoutTests/fast/forms/ValidityState-valueMissing-001.html 2011-06-21 03:00:16 UTC (rev 89332)
@@ -85,7 +85,7 @@
shouldBeFalse('valueMissingFor("select-fake-placeholder-selected-size2-multiple")');
shouldBeFalse('valueMissingFor("select-without-fake-placeholder-size2-multiple")');
shouldBeFalse('valueMissingFor("select-optgroup")');
- shouldBeFalse('valueMissingFor("select-disabled-option")');
+ shouldBeTrue('valueMissingFor("select-disabled-option")');
var successfullyParsed = true;
</script>
Modified: trunk/Source/WebCore/ChangeLog (89331 => 89332)
--- trunk/Source/WebCore/ChangeLog 2011-06-21 02:58:22 UTC (rev 89331)
+++ trunk/Source/WebCore/ChangeLog 2011-06-21 03:00:16 UTC (rev 89332)
@@ -1,3 +1,13 @@
+2011-06-20 Dai Mikurube <[email protected]>
+
+ Reviewed by Kent Tamura.
+
+ Webkit allows disabled option as value of "required" select
+ https://bugs.webkit.org/show_bug.cgi?id=62668
+
+ * html/HTMLSelectElement.cpp: Removed "disabled" checking due to spec change.
+ (WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
+
2011-06-20 Zhenyao Mo <[email protected]>
Reviewed by Kenneth Russell.
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (89331 => 89332)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-06-21 02:58:22 UTC (rev 89331)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-06-21 03:00:16 UTC (rev 89332)
@@ -129,7 +129,7 @@
if (listIndex < 0)
return false;
HTMLOptionElement* option = static_cast<HTMLOptionElement*>(listItems()[listIndex]);
- return !option->disabled() && !listIndex && option->value().isEmpty();
+ return !listIndex && option->value().isEmpty();
}
bool HTMLSelectElement::valueMissing() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
