Title: [89398] trunk/Source/WebKit2
- Revision
- 89398
- Author
- jer.no...@apple.com
- Date
- 2011-06-21 17:50:13 -0700 (Tue, 21 Jun 2011)
Log Message
2011-06-21 Jer Noble <jer.no...@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Fullscreen videos are broken (affects embedded vimeo, vimeo.com, and apple.com)
https://bugs.webkit.org/show_bug.cgi?id=63098
<rdar://problem/9645393>
Force a repaint after completing entering full-screen mode only after the notification
is sent for the QTMovie to tear down its layer. Then, the QTMovie will build up its
layer again during the repaint.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89397 => 89398)
--- trunk/Source/WebKit2/ChangeLog 2011-06-22 00:40:41 UTC (rev 89397)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-22 00:50:13 UTC (rev 89398)
@@ -1,3 +1,18 @@
+2011-06-21 Jer Noble <jer.no...@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ REGRESSION: Fullscreen videos are broken (affects embedded vimeo, vimeo.com, and apple.com)
+ https://bugs.webkit.org/show_bug.cgi?id=63098
+ <rdar://problem/9645393>
+
+ Force a repaint after completing entering full-screen mode only after the notification
+ is sent for the QTMovie to tear down its layer. Then, the QTMovie will build up its
+ layer again during the repaint.
+
+ * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
+ (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
+
2011-06-21 Yael Aharon <yael.aha...@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Modified: trunk/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm (89397 => 89398)
--- trunk/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm 2011-06-22 00:40:41 UTC (rev 89397)
+++ trunk/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm 2011-06-22 00:50:13 UTC (rev 89398)
@@ -138,14 +138,14 @@
return;
if (!layer) {
- m_page->forceRepaintWithoutCallback();
- m_page->send(Messages::WebFullScreenManagerProxy::ExitAcceleratedCompositingMode());
-
PlatformLayer* rootPlatformLayer = m_rootLayer->platformLayer();
[[NSNotificationCenter defaultCenter] postNotificationName:@"WebKitLayerHostChanged" object:rootPlatformLayer userInfo:nil];
m_rootLayer->removeAllChildren();
m_rootLayer->syncCompositingStateForThisLayerOnly();
m_rootLayer = nullptr;
+
+ m_page->forceRepaintWithoutCallback();
+ m_page->send(Messages::WebFullScreenManagerProxy::ExitAcceleratedCompositingMode());
return;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
