Title: [89479] trunk
- Revision
- 89479
- Author
- [email protected]
- Date
- 2011-06-22 14:23:16 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Mark Pilgrim <[email protected]>
Reviewed by Adam Barth.
IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114
* storage/indexeddb/mozilla/create-index-null-name-expected.txt:
* storage/indexeddb/mozilla/create-index-null-name.html:
2011-06-22 Mark Pilgrim <[email protected]>
Reviewed by Adam Barth.
IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114
* storage/IDBObjectStore.idl: remove ConvertNullToNullString flag
so null values will be stringified as "null", as per WebIDL spec.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (89478 => 89479)
--- trunk/LayoutTests/ChangeLog 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 21:23:16 UTC (rev 89479)
@@ -1,3 +1,13 @@
+2011-06-22 Mark Pilgrim <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ IndexedDB createIndex should NOT throw if name arg is null
+ https://bugs.webkit.org/show_bug.cgi?id=63114
+
+ * storage/indexeddb/mozilla/create-index-null-name-expected.txt:
+ * storage/indexeddb/mozilla/create-index-null-name.html:
+
2011-06-22 Jessie Berlin <[email protected]>
REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on
Modified: trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt (89478 => 89479)
--- trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt 2011-06-22 21:23:16 UTC (rev 89479)
@@ -12,9 +12,9 @@
request = db.setVersion('1')
Deleted all object stores.
objectStore = db.createObjectStore('a', { keyPath: 'id', autoIncrement: true });
-Expecting exception from index = objectStore.createIndex(null, null);
-PASS Exception was thrown.
-PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
+index = objectStore.createIndex(null, null);
+PASS index.name is 'null'
+PASS index.keyPath is 'null'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html (89478 => 89479)
--- trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html 2011-06-22 21:23:16 UTC (rev 89479)
@@ -50,7 +50,9 @@
objectStore = evalAndLog("objectStore = db.createObjectStore('a', { keyPath: 'id', autoIncrement: true });");
- index = evalAndExpectException("index = objectStore.createIndex(null, null);", "IDBDatabaseException.NON_TRANSIENT_ERR");
+ index = evalAndLog("index = objectStore.createIndex(null, null);");
+ shouldBe("index.name", "'null'");
+ shouldBe("index.keyPath", "'null'");
done();
}
Modified: trunk/Source/WebCore/ChangeLog (89478 => 89479)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 21:23:16 UTC (rev 89479)
@@ -1,3 +1,13 @@
+2011-06-22 Mark Pilgrim <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ IndexedDB createIndex should NOT throw if name arg is null
+ https://bugs.webkit.org/show_bug.cgi?id=63114
+
+ * storage/IDBObjectStore.idl: remove ConvertNullToNullString flag
+ so null values will be stringified as "null", as per WebIDL spec.
+
2011-06-22 Chris Rogers <[email protected]>
Reviewed by Kenneth Russell.
Modified: trunk/Source/WebCore/storage/IDBObjectStore.idl (89478 => 89479)
--- trunk/Source/WebCore/storage/IDBObjectStore.idl 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/Source/WebCore/storage/IDBObjectStore.idl 2011-06-22 21:23:16 UTC (rev 89479)
@@ -44,7 +44,7 @@
raises (IDBDatabaseException);
[CallWith=ScriptExecutionContext] IDBRequest openCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction)
raises (IDBDatabaseException);
- IDBIndex createIndex(in [ConvertNullToNullString] DOMString name, in [ConvertNullToNullString] DOMString keyPath, in [Optional] OptionsObject options)
+ IDBIndex createIndex(in DOMString name, in DOMString keyPath, in [Optional] OptionsObject options)
raises (IDBDatabaseException);
IDBIndex index(in DOMString name)
raises (IDBDatabaseException);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
