Title: [89520] trunk/Tools
- Revision
- 89520
- Author
- [email protected]
- Date
- 2011-06-22 19:14:30 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Eric Seidel <[email protected]>
Reviewed by Adam Barth.
Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107
itertools.chain.from_iterable is new in 2.6,
use itertools.chain(*list) for 2.5 compat.
* Scripts/webkitpy/tool/bot/irc_command.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (89519 => 89520)
--- trunk/Tools/ChangeLog 2011-06-23 02:09:22 UTC (rev 89519)
+++ trunk/Tools/ChangeLog 2011-06-23 02:14:30 UTC (rev 89520)
@@ -2,6 +2,18 @@
Reviewed by Adam Barth.
+ Make sheriff-bot rollout messages a little nicer
+ https://bugs.webkit.org/show_bug.cgi?id=63107
+
+ itertools.chain.from_iterable is new in 2.6,
+ use itertools.chain(*list) for 2.5 compat.
+
+ * Scripts/webkitpy/tool/bot/irc_command.py:
+
+2011-06-22 Eric Seidel <[email protected]>
+
+ Reviewed by Adam Barth.
+
Make sheriff-bot robust against exceptions from commands
https://bugs.webkit.org/show_bug.cgi?id=63211
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (89519 => 89520)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-06-23 02:09:22 UTC (rev 89519)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-06-23 02:14:30 UTC (rev 89520)
@@ -81,7 +81,7 @@
def _responsible_nicknames_from_revisions(self, tool, sheriff, svn_revision_list):
commit_infos = map(tool.checkout().commit_info_for_revision, svn_revision_list)
nickname_lists = map(sheriff.responsible_nicknames_from_commit_info, commit_infos)
- return sorted(set(itertools.chain.from_iterable(nickname_lists)))
+ return sorted(set(itertools.chain(*nickname_lists)))
def _nicks_string(self, tool, sheriff, requester_nick, svn_revision_list):
# FIXME: _parse_args guarentees that our svn_revision_list is all numbers.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
