Title: [89528] branches/safari-534-branch/Source/WebKit2
Diff
Modified: branches/safari-534-branch/Source/WebKit2/ChangeLog (89527 => 89528)
--- branches/safari-534-branch/Source/WebKit2/ChangeLog 2011-06-23 04:18:16 UTC (rev 89527)
+++ branches/safari-534-branch/Source/WebKit2/ChangeLog 2011-06-23 04:19:31 UTC (rev 89528)
@@ -1,5 +1,27 @@
2011-06-22 Lucas Forschler <[email protected]>
+ Merged 89436.
+
+ 2011-06-22 Adam Roben <[email protected]>
+
+ Don't use an alpha channel when drawing the web page on Windows
+
+ We never use the alpha channel in the end anyway (because we never render into a layered
+ window, which is the only kind of window that supports alpha). And using an alpha channel is
+ tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
+ channel).
+
+ Fixes <http://webkit.org/b/63075> <rdar://problem/9648113> REGRESSION (r88978): Text inside
+ form controls looks really awful on Windows XP
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
+ (WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
+ to the GraphicsContext constructor.
+
+2011-06-22 Lucas Forschler <[email protected]>
+
Merged 89398.
2011-06-21 Jer Noble <[email protected]>
Modified: branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp (89527 => 89528)
--- branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp 2011-06-23 04:18:16 UTC (rev 89527)
+++ branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp 2011-06-23 04:19:31 UTC (rev 89528)
@@ -54,7 +54,10 @@
PassOwnPtr<GraphicsContext> DrawingAreaImpl::createGraphicsContext(ShareableBitmap* bitmap)
{
HDC bitmapDC = bitmap->windowsContext();
- return adoptPtr(new GraphicsContext(bitmapDC, true));
+ // FIXME: We should really be checking m_webPage->draws[Transparent]Background() to determine
+ // whether to have an alpha channel or not. But currently we always render into a non-layered
+ // window, so the alpha channel doesn't matter anyway.
+ return adoptPtr(new GraphicsContext(bitmapDC, false));
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
