Title: [89568] trunk/Tools
- Revision
- 89568
- Author
- [email protected]
- Date
- 2011-06-23 07:34:37 -0700 (Thu, 23 Jun 2011)
Log Message
Don't count new tests as failures on the TestFailures page
Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
they aren't
Reviewed by Anders Carlsson.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
of failures.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (89567 => 89568)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-06-23 14:23:02 UTC (rev 89567)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-06-23 14:34:37 UTC (rev 89568)
@@ -128,6 +128,9 @@
var match = /^(\d+) test case/.exec(outputLine);
if (!match)
return sum;
+ // Don't count new tests as failures.
+ if (outputLine.indexOf('were new') >= 0)
+ return sum;
return sum + parseInt(match[1], 10);
}, 0);
Modified: trunk/Tools/ChangeLog (89567 => 89568)
--- trunk/Tools/ChangeLog 2011-06-23 14:23:02 UTC (rev 89567)
+++ trunk/Tools/ChangeLog 2011-06-23 14:34:37 UTC (rev 89568)
@@ -1,3 +1,16 @@
+2011-06-23 Adam Roben <[email protected]>
+
+ Don't count new tests as failures on the TestFailures page
+
+ Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
+ they aren't
+
+ Reviewed by Anders Carlsson.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
+ (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
+ of failures.
+
2011-06-23 Dirk Pranke <[email protected]>
Reviewed by Eric Seidel.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
