Title: [89662] trunk/Source/WebCore
- Revision
- 89662
- Author
- [email protected]
- Date
- 2011-06-24 03:39:29 -0700 (Fri, 24 Jun 2011)
Log Message
2011-06-24 Vsevolod Vlasov <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: HTML preview should delete old iframe on show().
https://bugs.webkit.org/show_bug.cgi?id=63170
* inspector/front-end/ResourceHTMLView.js:
(WebInspector.ResourceHTMLView.prototype._createIFrame):
* inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype.contentLoaded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89661 => 89662)
--- trunk/Source/WebCore/ChangeLog 2011-06-24 10:21:27 UTC (rev 89661)
+++ trunk/Source/WebCore/ChangeLog 2011-06-24 10:39:29 UTC (rev 89662)
@@ -1,3 +1,15 @@
+2011-06-24 Vsevolod Vlasov <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: HTML preview should delete old iframe on show().
+ https://bugs.webkit.org/show_bug.cgi?id=63170
+
+ * inspector/front-end/ResourceHTMLView.js:
+ (WebInspector.ResourceHTMLView.prototype._createIFrame):
+ * inspector/front-end/ResourcePreviewView.js:
+ (WebInspector.ResourcePreviewView.prototype.contentLoaded):
+
2011-06-24 Dirk Schulze <[email protected]>
Reviewed by Nikolas Zimmermann.
Modified: trunk/Source/WebCore/inspector/front-end/ResourceHTMLView.js (89661 => 89662)
--- trunk/Source/WebCore/inspector/front-end/ResourceHTMLView.js 2011-06-24 10:21:27 UTC (rev 89661)
+++ trunk/Source/WebCore/inspector/front-end/ResourceHTMLView.js 2011-06-24 10:39:29 UTC (rev 89662)
@@ -56,6 +56,7 @@
{
// We need to create iframe again each time because contentDocument
// is deleted when iframe is removed from its parent.
+ this.element.removeChildren();
var iframe = document.createElement("iframe");
this.element.appendChild(iframe);
iframe.setAttribute("sandbox", ""); // Forbid to run _javascript_ and set unique origin.
Modified: trunk/Source/WebCore/inspector/front-end/ResourcePreviewView.js (89661 => 89662)
--- trunk/Source/WebCore/inspector/front-end/ResourcePreviewView.js 2011-06-24 10:21:27 UTC (rev 89661)
+++ trunk/Source/WebCore/inspector/front-end/ResourcePreviewView.js 2011-06-24 10:39:29 UTC (rev 89662)
@@ -47,8 +47,9 @@
this._emptyView.detach();
delete this._emptyView;
}
- var view = this._createInnerView();
- view.show(this.element);
+ if (!this._view)
+ this._view = this._createInnerView();
+ this._view.show(this.element);
}
},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes