Title: [89698] trunk/Tools
- Revision
- 89698
- Author
- [email protected]
- Date
- 2011-06-24 12:56:57 -0700 (Fri, 24 Jun 2011)
Log Message
Fix typos introduced in r89696
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (89697 => 89698)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-06-24 19:49:28 UTC (rev 89697)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-06-24 19:56:57 UTC (rev 89698)
@@ -109,14 +109,14 @@
var layoutTestStep = data.steps.findFirst(function(step) { return step.name === 'layout-test'; });
if (!layoutTestStep) {
PersistentCache.set(cacheKey, result);
- callback(PersistentCache.get(cacheKey), false);
+ callback(result.failureCount, result.tooManyFailures);
return;
}
if (!('isStarted' in layoutTestStep)) {
// run-webkit-tests never even ran.
PersistentCache.set(cacheKey, result);
- callback(PersistentCache.get(cacheKey), false);
+ callback(result.failureCount, result.tooManyFailures);
return;
}
@@ -124,7 +124,7 @@
// All tests passed.
result.failureCount = 0;
PersistentCache.set(cacheKey, result);
- callback(PersistentCache.get(cacheKey), false);
+ callback(result.failureCount, result.tooManyFailures);
return;
}
Modified: trunk/Tools/ChangeLog (89697 => 89698)
--- trunk/Tools/ChangeLog 2011-06-24 19:49:28 UTC (rev 89697)
+++ trunk/Tools/ChangeLog 2011-06-24 19:56:57 UTC (rev 89698)
@@ -1,5 +1,13 @@
2011-06-24 Adam Roben <[email protected]>
+ Fix typos introduced in r89696
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
+ (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
+ callback, since that's what it expects.
+
+2011-06-24 Adam Roben <[email protected]>
+
Make TestFailures correctly remember whether old-run-webkit-tests exited early
Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
