Title: [89720] trunk/Source/WebKit2
- Revision
- 89720
- Author
- [email protected]
- Date
- 2011-06-24 17:45:00 -0700 (Fri, 24 Jun 2011)
Log Message
2011-06-24 Anders Carlsson <[email protected]>
Reviewed by John Sullivan.
Drag-and-drop tab in same window makes web process falsely report unresponsiveness
https://bugs.webkit.org/show_bug.cgi?id=63369
<rdar://problem/9673120>
If the view becomes invisible, stop the responsiveness timer, because we might not get any
messages that will cause it to stop (such as painting notifications since we don't paint
when we're not visible).
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89719 => 89720)
--- trunk/Source/WebKit2/ChangeLog 2011-06-25 00:39:33 UTC (rev 89719)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-25 00:45:00 UTC (rev 89720)
@@ -1,5 +1,20 @@
2011-06-24 Anders Carlsson <[email protected]>
+ Reviewed by John Sullivan.
+
+ Drag-and-drop tab in same window makes web process falsely report unresponsiveness
+ https://bugs.webkit.org/show_bug.cgi?id=63369
+ <rdar://problem/9673120>
+
+ If the view becomes invisible, stop the responsiveness timer, because we might not get any
+ messages that will cause it to stop (such as painting notifications since we don't paint
+ when we're not visible).
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::viewStateDidChange):
+
+2011-06-24 Anders Carlsson <[email protected]>
+
Reviewed by Kevin Decker.
Not possible for plug-ins to override the internal PDF viewer
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (89719 => 89720)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-06-25 00:39:33 UTC (rev 89719)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-06-25 00:45:00 UTC (rev 89720)
@@ -661,6 +661,13 @@
m_isVisible = isVisible;
m_drawingArea->visibilityDidChange();
m_drawingArea->setPageIsVisible(isVisible);
+
+ if (!m_isVisible) {
+ // If we've started the responsiveness timer as part of telling the web process to update the backing store
+ // state, it might not send back a reply (since it won't paint anything if the web page is hidden) so we
+ // stop the unresponsiveness timer here.
+ process()->responsivenessTimer()->stop();
+ }
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
