Title: [89748] trunk/Source/WebCore
- Revision
- 89748
- Author
- [email protected]
- Date
- 2011-06-25 14:20:22 -0700 (Sat, 25 Jun 2011)
Log Message
2011-06-25 Jer Noble <[email protected]>
Reviewed by Maciej Stachowiak.
SOFT_LINK_POINTER_OPTIONAL isn't optional.
https://bugs.webkit.org/show_bug.cgi?id=63378
Continuation of r89718. SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.
* platform/mac/SoftLinking.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89747 => 89748)
--- trunk/Source/WebCore/ChangeLog 2011-06-25 19:02:07 UTC (rev 89747)
+++ trunk/Source/WebCore/ChangeLog 2011-06-25 21:20:22 UTC (rev 89748)
@@ -1,3 +1,14 @@
+2011-06-25 Jer Noble <[email protected]>
+
+ Reviewed by Maciej Stachowiak.
+
+ SOFT_LINK_POINTER_OPTIONAL isn't optional.
+ https://bugs.webkit.org/show_bug.cgi?id=63378
+
+ Continuation of r89718. SOFT_LINK_POINTER_OPTIONAL should check the value returned by dlsym before dereferencing it.
+
+ * platform/mac/SoftLinking.h:
+
2011-06-25 Rob Buis <[email protected]>
Reviewed by Nikolas Zimmermann.
Modified: trunk/Source/WebCore/platform/mac/SoftLinking.h (89747 => 89748)
--- trunk/Source/WebCore/platform/mac/SoftLinking.h 2011-06-25 19:02:07 UTC (rev 89747)
+++ trunk/Source/WebCore/platform/mac/SoftLinking.h 2011-06-25 21:20:22 UTC (rev 89748)
@@ -137,7 +137,8 @@
static type init##name() \
{ \
void** pointer = static_cast<void**>(dlsym(framework##Library(), #name)); \
- pointer##name = static_cast<type>(*pointer); \
+ if (pointer) \
+ pointer##name = static_cast<type>(*pointer); \
get##name = name##Function; \
return pointer##name; \
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
