Title: [89852] trunk/Tools
- Revision
- 89852
- Author
- [email protected]
- Date
- 2011-06-27 14:18:32 -0700 (Mon, 27 Jun 2011)
Log Message
2011-06-27 Adam Barth <[email protected]>
Reviewed by Dirk Pranke.
webkitpy unit tests should have more descriptive names than just "Test"
https://bugs.webkit.org/show_bug.cgi?id=63479
Luckily we kept these classes in separate namespaces in the harness so
we were actually running them all even though they had the same name.
* Scripts/webkitpy/common/system/stack_utils_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
* Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (89851 => 89852)
--- trunk/Tools/ChangeLog 2011-06-27 21:09:53 UTC (rev 89851)
+++ trunk/Tools/ChangeLog 2011-06-27 21:18:32 UTC (rev 89852)
@@ -1,3 +1,17 @@
+2011-06-27 Adam Barth <[email protected]>
+
+ Reviewed by Dirk Pranke.
+
+ webkitpy unit tests should have more descriptive names than just "Test"
+ https://bugs.webkit.org/show_bug.cgi?id=63479
+
+ Luckily we kept these classes in separate namespaces in the harness so
+ we were actually running them all even though they had the same name.
+
+ * Scripts/webkitpy/common/system/stack_utils_unittest.py:
+ * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
+ * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
+
2011-06-27 Greg Simon <[email protected]>
No review necessary.
Modified: trunk/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py (89851 => 89852)
--- trunk/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py 2011-06-27 21:09:53 UTC (rev 89851)
+++ trunk/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py 2011-06-27 21:18:32 UTC (rev 89852)
@@ -38,7 +38,7 @@
return thread_id
-class Test(unittest.TestCase):
+class StackUtilsTest(unittest.TestCase):
def test_find_thread_stack_found(self):
thread_id = current_thread_id()
found_stack = stack_utils._find_thread_stack(thread_id)
@@ -70,7 +70,3 @@
except:
stack_utils.log_traceback(logger, sys.exc_info()[2])
self.assertTrue(msgs)
-
-
-if __name__ == '__main__':
- unittest.main()
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py (89851 => 89852)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py 2011-06-27 21:09:53 UTC (rev 89851)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py 2011-06-27 21:18:32 UTC (rev 89852)
@@ -33,7 +33,7 @@
from webkitpy.layout_tests.layout_package.test_failures import *
-class Test(unittest.TestCase):
+class TestFailuresest(unittest.TestCase):
def assert_loads(self, cls):
failure_obj = cls()
s = failure_obj.dumps()
@@ -83,6 +83,3 @@
# The hash happens to be the name of the class, but sets still work:
crash_set = set([FailureCrash(), "FailureCrash"])
self.assertEqual(len(crash_set), 2)
-
-if __name__ == '__main__':
- unittest.main()
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py (89851 => 89852)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py 2011-06-27 21:09:53 UTC (rev 89851)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py 2011-06-27 21:18:32 UTC (rev 89852)
@@ -31,7 +31,7 @@
from test_results import TestResult
-class Test(unittest.TestCase):
+class TestResultsTest(unittest.TestCase):
def test_defaults(self):
result = TestResult("foo")
self.assertEqual(result.filename, 'foo')
@@ -50,7 +50,3 @@
# Also check that != is implemented.
self.assertFalse(new_result != result)
-
-
-if __name__ == '__main__':
- unittest.main()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
