Title: [89962] trunk/Tools
- Revision
- 89962
- Author
- [email protected]
- Date
- 2011-06-28 14:44:17 -0700 (Tue, 28 Jun 2011)
Log Message
2011-06-28 Eric Seidel <[email protected]>
Reviewed by Tony Chang.
new-run-webkit-tests needs a --webkit-test-runner option
https://bugs.webkit.org/show_bug.cgi?id=63439
This was accidentally fixed in bug 63501 as well.
The root problem here was that the webkit unit tests were not using
enough mocks. I've fixed them here to use more mocks
which should unbreak windows.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (89961 => 89962)
--- trunk/Tools/ChangeLog 2011-06-28 21:33:38 UTC (rev 89961)
+++ trunk/Tools/ChangeLog 2011-06-28 21:44:17 UTC (rev 89962)
@@ -2,6 +2,20 @@
Reviewed by Tony Chang.
+ new-run-webkit-tests needs a --webkit-test-runner option
+ https://bugs.webkit.org/show_bug.cgi?id=63439
+
+ This was accidentally fixed in bug 63501 as well.
+ The root problem here was that the webkit unit tests were not using
+ enough mocks. I've fixed them here to use more mocks
+ which should unbreak windows.
+
+ * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+
+2011-06-28 Eric Seidel <[email protected]>
+
+ Reviewed by Tony Chang.
+
new-run-webkit-tests should not run mthml tests when MHTML support is disabled
https://bugs.webkit.org/show_bug.cgi?id=63549
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (89961 => 89962)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-06-28 21:33:38 UTC (rev 89961)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-06-28 21:44:17 UTC (rev 89962)
@@ -33,20 +33,22 @@
from webkitpy.layout_tests.port.webkit import WebKitPort
from webkitpy.layout_tests.port import port_testcase
-from webkitpy.tool.mocktool import MockExecutive
-from webkitpy.tool.mocktool import MockOptions
+from webkitpy.tool.mocktool import MockExecutive, MockOptions, MockUser
class TestWebKitPort(WebKitPort):
def __init__(self, symbol_list=None, feature_list=None,
expectations_file=None, skips_file=None,
- executive=None, **kwargs):
+ executive=None, filesystem=None, user=None,
+ **kwargs):
self.symbol_list = symbol_list
self.feature_list = feature_list
self.expectations_file = expectations_file
self.skips_file = skips_file
executive = executive or MockExecutive(should_log=False)
- WebKitPort.__init__(self, executive=executive, **kwargs)
+ filesystem = filesystem or filesystem_mock.MockFileSystem()
+ user = user or MockUser()
+ WebKitPort.__init__(self, executive=executive, filesystem=filesystem, user=MockUser(), **kwargs)
def _runtime_feature_list(self):
return self.feature_list
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
