Title: [89972] trunk
- Revision
- 89972
- Author
- [email protected]
- Date
- 2011-06-28 16:11:30 -0700 (Tue, 28 Jun 2011)
Log Message
2011-06-27 Diego Gonzalez <[email protected]>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=63496
Unskipped:
fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-attach-assertion.html
fast/forms/interactive-validation-assertion-by-validate-twice.html
fast/forms/interactive-validation-select-crash.html
fast/forms/interactive-validation-crash-by-style-override.html
Source/WebKit/qt:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
LayoutTests:
* platform/qt/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (89971 => 89972)
--- trunk/LayoutTests/ChangeLog 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/LayoutTests/ChangeLog 2011-06-28 23:11:30 UTC (rev 89972)
@@ -1,3 +1,12 @@
+2011-06-27 Diego Gonzalez <[email protected]>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] DRT support for setInteractiveFormValidationEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=63496
+
+ * platform/qt/Skipped:
+
2011-06-28 Nate Chapin <[email protected]>
Unreviewed, chromium test update for r89951.
Modified: trunk/LayoutTests/platform/qt/Skipped (89971 => 89972)
--- trunk/LayoutTests/platform/qt/Skipped 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-06-28 23:11:30 UTC (rev 89972)
@@ -2010,12 +2010,6 @@
http/tests/security/401-logout/401-logout.php
http/tests/xmlhttprequest/remember-bad-password.html
-# Need to call Settings::setInteractiveFormValidationEnabled(true).
-fast/forms/interactive-validation-prevented.html
-fast/forms/interactive-validation-attach-assertion.html
-fast/forms/interactive-validation-assertion-by-validate-twice.html
-fast/forms/interactive-validation-select-crash.html
-fast/forms/interactive-validation-crash-by-style-override.html
# Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT.
fast/forms/validation-message-appearance.html
fast/forms/validation-message-clone.html
Modified: trunk/Source/WebKit/qt/ChangeLog (89971 => 89972)
--- trunk/Source/WebKit/qt/ChangeLog 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-06-28 23:11:30 UTC (rev 89972)
@@ -1,3 +1,21 @@
+2011-06-27 Diego Gonzalez <[email protected]>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] DRT support for setInteractiveFormValidationEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=63496
+
+ Unskipped:
+ fast/forms/interactive-validation-prevented.html
+ fast/forms/interactive-validation-attach-assertion.html
+ fast/forms/interactive-validation-assertion-by-validate-twice.html
+ fast/forms/interactive-validation-select-crash.html
+ fast/forms/interactive-validation-crash-by-style-override.html
+
+ * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+ (DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
+ * WebCoreSupport/DumpRenderTreeSupportQt.h:
+
2011-06-28 Alexis Menard <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp (89971 => 89972)
--- trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp 2011-06-28 23:11:30 UTC (rev 89972)
@@ -1009,6 +1009,13 @@
FrameLoaderClientQt::URLsToRedirect[origin] = destination;
}
+void DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled(QWebPage* page, bool enable)
+{
+ Page* corePage = QWebPagePrivate::core(page);
+ if (corePage)
+ corePage->settings()->setInteractiveFormValidationEnabled(enable);
+}
+
static QStringList iterateContextMenu(QMenu* menu)
{
if (!menu)
Modified: trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h (89971 => 89972)
--- trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h 2011-06-28 23:11:30 UTC (rev 89972)
@@ -212,6 +212,8 @@
static QString layerTreeAsText(QWebFrame*);
static void injectInternalsObject(QWebFrame*);
+
+ static void setInteractiveFormValidationEnabled(QWebPage*, bool);
};
#endif
Modified: trunk/Tools/ChangeLog (89971 => 89972)
--- trunk/Tools/ChangeLog 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/Tools/ChangeLog 2011-06-28 23:11:30 UTC (rev 89972)
@@ -1,3 +1,13 @@
+2011-06-27 Diego Gonzalez <[email protected]>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ [Qt] DRT support for setInteractiveFormValidationEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=63496
+
+ * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+ (WebCore::DumpRenderTree::DumpRenderTree):
+
2011-06-28 Eric Seidel <[email protected]>
Reviewed by Adam Barth.
Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (89971 => 89972)
--- trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2011-06-28 23:06:20 UTC (rev 89971)
+++ trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2011-06-28 23:11:30 UTC (rev 89972)
@@ -466,6 +466,7 @@
QObject::connect(this, SIGNAL(quit()), qApp, SLOT(quit()), Qt::QueuedConnection);
DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled(true);
+ DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled(webPage(), true);
QFocusEvent event(QEvent::FocusIn, Qt::ActiveWindowFocusReason);
QApplication::sendEvent(m_mainView, &event);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
