Title: [90003] trunk/Source/WebCore
- Revision
- 90003
- Author
- [email protected]
- Date
- 2011-06-29 02:32:21 -0700 (Wed, 29 Jun 2011)
Log Message
2011-06-29 Ryan Sleevi <[email protected]>
Reviewed by Dirk Schulze.
SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
https://bugs.webkit.org/show_bug.cgi?id=61600
Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()
No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (90002 => 90003)
--- trunk/Source/WebCore/ChangeLog 2011-06-29 09:29:14 UTC (rev 90002)
+++ trunk/Source/WebCore/ChangeLog 2011-06-29 09:32:21 UTC (rev 90003)
@@ -1,3 +1,19 @@
+2011-06-29 Ryan Sleevi <[email protected]>
+
+ Reviewed by Dirk Schulze.
+
+ SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
+ https://bugs.webkit.org/show_bug.cgi?id=61600
+
+ Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()
+
+ No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
+ expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
+ different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.
+
+ * svg/SVGRadialGradientElement.cpp:
+ (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
+
2011-06-28 Dirk Schulze <[email protected]>
Reviewed by Nikolas Zimmermann.
Modified: trunk/Source/WebCore/svg/SVGRadialGradientElement.cpp (90002 => 90003)
--- trunk/Source/WebCore/svg/SVGRadialGradientElement.cpp 2011-06-29 09:29:14 UTC (rev 90002)
+++ trunk/Source/WebCore/svg/SVGRadialGradientElement.cpp 2011-06-29 09:32:21 UTC (rev 90003)
@@ -305,7 +305,7 @@
bool SVGRadialGradientElement::selfHasRelativeLengths() const
{
- return cy().isRelative()
+ return cx().isRelative()
|| cy().isRelative()
|| r().isRelative()
|| fx().isRelative()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
