Title: [90022] trunk
- Revision
- 90022
- Author
- [email protected]
- Date
- 2011-06-29 09:22:53 -0700 (Wed, 29 Jun 2011)
Log Message
2011-06-29 Vsevolod Vlasov <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
https://bugs.webkit.org/show_bug.cgi?id=63631
* http/tests/inspector/network/network-request-revision-content-expected.txt: Added.
* http/tests/inspector/network/network-request-revision-content.html: Added.
* http/tests/inspector/network/resources/script.js: Added.
2011-06-29 Vsevolod Vlasov <[email protected]>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
https://bugs.webkit.org/show_bug.cgi?id=63631
Test: http/tests/inspector/network/network-request-revision-content.html
* inspector/front-end/Resource.js:
(WebInspector.ResourceRevision.prototype.requestContent):
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90021 => 90022)
--- trunk/LayoutTests/ChangeLog 2011-06-29 16:15:48 UTC (rev 90021)
+++ trunk/LayoutTests/ChangeLog 2011-06-29 16:22:53 UTC (rev 90022)
@@ -1,3 +1,14 @@
+2011-06-29 Vsevolod Vlasov <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
+ https://bugs.webkit.org/show_bug.cgi?id=63631
+
+ * http/tests/inspector/network/network-request-revision-content-expected.txt: Added.
+ * http/tests/inspector/network/network-request-revision-content.html: Added.
+ * http/tests/inspector/network/resources/script.js: Added.
+
2011-06-29 Balazs Kelemen <[email protected]>
Reviewed by Kenneth Rohde Christiansen.
Added: trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt (0 => 90022)
--- trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt 2011-06-29 16:22:53 UTC (rev 90022)
@@ -0,0 +1,7 @@
+CONSOLE MESSAGE: line 1: Done.
+Tests how resource revision requests content if it was not yet loaded for resource itself.
+
+Bug 63631
+http://127.0.0.1:8000/inspector/network/resources/script.js
+
+
Added: trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html (0 => 90022)
--- trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html 2011-06-29 16:22:53 UTC (rev 90022)
@@ -0,0 +1,38 @@
+<html>
+<head>
+<script src=""
+<script>
+function loadScript()
+{
+ var js = document.createElement("script");
+ js.src = ""
+ document.head.appendChild(js);
+}
+
+function test()
+{
+ InspectorTest.addSniffer(WebInspector.ConsoleView.prototype, "addMessage", step2, true);
+ InspectorTest.evaluateInPage("loadScript()");
+
+ function step2(msg)
+ {
+ var resource = WebInspector.panels.network.resources[WebInspector.panels.network.resources.length - 1];
+ resource.addRevision("");
+ resource.history[0].requestContent(step3);
+ }
+
+ function step3()
+ {
+ var resource = WebInspector.panels.network.resources[WebInspector.panels.network.resources.length - 1];
+ InspectorTest.addResult(resource.url);
+ InspectorTest.addResult(resource.content);
+ InspectorTest.completeTest();
+ }
+}
+</script>
+</head>
+<body _onload_="runTest()">
+<p>Tests how resource revision requests content if it was not yet loaded for resource itself.</p>
+<a href="" 63631</a>
+</body>
+</html>
Added: trunk/LayoutTests/http/tests/inspector/network/resources/script.js (0 => 90022)
--- trunk/LayoutTests/http/tests/inspector/network/resources/script.js (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/resources/script.js 2011-06-29 16:22:53 UTC (rev 90022)
@@ -0,0 +1 @@
+console.log("Done.");
Modified: trunk/Source/WebCore/ChangeLog (90021 => 90022)
--- trunk/Source/WebCore/ChangeLog 2011-06-29 16:15:48 UTC (rev 90021)
+++ trunk/Source/WebCore/ChangeLog 2011-06-29 16:22:53 UTC (rev 90022)
@@ -1,3 +1,15 @@
+2011-06-29 Vsevolod Vlasov <[email protected]>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
+ https://bugs.webkit.org/show_bug.cgi?id=63631
+
+ Test: http/tests/inspector/network/network-request-revision-content.html
+
+ * inspector/front-end/Resource.js:
+ (WebInspector.ResourceRevision.prototype.requestContent):
+
2011-06-29 Igor Oliveira <[email protected]>
Reviewed by Andreas Kling.
Modified: trunk/Source/WebCore/inspector/front-end/Resource.js (90021 => 90022)
--- trunk/Source/WebCore/inspector/front-end/Resource.js 2011-06-29 16:15:48 UTC (rev 90021)
+++ trunk/Source/WebCore/inspector/front-end/Resource.js 2011-06-29 16:22:53 UTC (rev 90022)
@@ -966,7 +966,7 @@
this._content = content;
callback(content);
}
- WebInspector.networkManager.requestContent(this._resource, false, mycallback.bind(this));
+ WebInspector.networkManager.requestContent(this._resource, mycallback.bind(this));
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
