Title: [90052] trunk/Tools
- Revision
- 90052
- Author
- [email protected]
- Date
- 2011-06-29 15:04:29 -0700 (Wed, 29 Jun 2011)
Log Message
2011-06-29 Eric Seidel <[email protected]>
Adam says cowboys don't review (or unit test).
* Scripts/webkitpy/tool/commands/download.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90051 => 90052)
--- trunk/Tools/ChangeLog 2011-06-29 21:56:50 UTC (rev 90051)
+++ trunk/Tools/ChangeLog 2011-06-29 22:04:29 UTC (rev 90052)
@@ -1,5 +1,11 @@
2011-06-29 Eric Seidel <[email protected]>
+ Adam says cowboys don't review (or unit test).
+
+ * Scripts/webkitpy/tool/commands/download.py:
+
+2011-06-29 Eric Seidel <[email protected]>
+
Reviewed by Adam Barth.
Make port/config.py mockable for easier unit testing
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download.py (90051 => 90052)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2011-06-29 21:56:50 UTC (rev 90051)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2011-06-29 22:04:29 UTC (rev 90052)
@@ -123,6 +123,7 @@
steps.Build,
steps.RunTests,
steps.Commit,
+ steps.CloseBugForLandDiff,
]
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (90051 => 90052)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-06-29 21:56:50 UTC (rev 90051)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-06-29 22:04:29 UTC (rev 90052)
@@ -106,7 +106,7 @@
expected_stderr = "Updating working directory\n2 reviewed patches found on bug 42.\nProcessing 2 patches from 1 bug.\nProcessing patch 197 from bug 42.\nProcessing patch 128 from bug 42.\n"
self.assert_execute_outputs(ApplyFromBug(), [42], options=options, expected_stderr=expected_stderr)
- def test_land_diff(self):
+ def test_land(self):
expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
mock_tool = MockTool()
mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
