Title: [90083] trunk/Tools
- Revision
- 90083
- Author
- [email protected]
- Date
- 2011-06-29 20:07:40 -0700 (Wed, 29 Jun 2011)
Log Message
2011-06-29 Kenichi Ishibashi <[email protected]>
Reviewed by Adam Barth.
check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
https://webkit.org/b/57360
Modify the regular _expression_ to match https scheme.
* Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
* Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90082 => 90083)
--- trunk/Tools/ChangeLog 2011-06-30 03:05:03 UTC (rev 90082)
+++ trunk/Tools/ChangeLog 2011-06-30 03:07:40 UTC (rev 90083)
@@ -1,3 +1,15 @@
+2011-06-29 Kenichi Ishibashi <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
+ https://webkit.org/b/57360
+
+ Modify the regular _expression_ to match https scheme.
+
+ * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
+ * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
+
2011-06-29 Adam Barth <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (90082 => 90083)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2011-06-30 03:05:03 UTC (rev 90082)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2011-06-30 03:07:40 UTC (rev 90083)
@@ -136,6 +136,23 @@
self.assertEquals(57569, parse_bug_id_from_changelog(commit_text))
+ commit_text = '''
+2011-03-29 Timothy Hatcher <[email protected]>
+
+ Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.
+
+ https://webkit.org/b/57354
+
+ Reviewed by Sam Weinig.
+
+ * English.lproj/Localizable.strings: Updated.
+ * StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
+ * platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so
+ extract-localizable-strings does not complain about unbalanced single quotes.
+ '''
+
+ self.assertEquals(57354, parse_bug_id_from_changelog(commit_text))
+
def test_latest_entry_parse(self):
changelog_contents = u"%s\n%s" % (self._example_entry, self._example_changelog)
changelog_file = StringIO(changelog_contents)
Modified: trunk/Tools/Scripts/webkitpy/common/config/urls.py (90082 => 90083)
--- trunk/Tools/Scripts/webkitpy/common/config/urls.py 2011-06-30 03:05:03 UTC (rev 90082)
+++ trunk/Tools/Scripts/webkitpy/common/config/urls.py 2011-06-30 03:07:40 UTC (rev 90083)
@@ -47,4 +47,4 @@
_bug_server_regex = "https?://%s/" % re.sub('\.', '\\.', bug_server_host)
bug_server_url = "https://%s/" % bug_server_host
bug_url_long = _bug_server_regex + r"show_bug\.cgi\?id=(?P<bug_id>\d+)(&ctype=xml)?"
-bug_url_short = r"http\://webkit\.org/b/(?P<bug_id>\d+)"
+bug_url_short = r"https?\://webkit\.org/b/(?P<bug_id>\d+)"
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
