Title: [90115] trunk/Tools
- Revision
- 90115
- Author
- [email protected]
- Date
- 2011-06-30 07:00:30 -0700 (Thu, 30 Jun 2011)
Log Message
Add a link to file a bug about TestFailures to the TestFailures page
Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
about TestFailures itself
Reviewed by Anders Carlsson.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(aside): Added some styles for the new link. It is positioned in the upper-right and
hopefully not to glaringly obvious.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype.loaded): Set up our main content element and auxiliary UI.
(ViewController.prototype._displayBuilder):
(ViewController.prototype._displayTesters):
Modify the main content element instead of the entire body, as there are other things in the
body that we want to preserve.
(ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
that contains a link to file a bug about the TestFailures page.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css (90114 => 90115)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css 2011-06-30 14:00:16 UTC (rev 90114)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css 2011-06-30 14:00:30 UTC (rev 90115)
@@ -1,3 +1,11 @@
+aside {
+ position: absolute;
+ top: 3px;
+ right: 5px;
+ color: #888;
+ font-size: 0.9em;
+}
+
ol {
list-style-type: none;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (90114 => 90115)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-06-30 14:00:16 UTC (rev 90114)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-06-30 14:00:30 UTC (rev 90115)
@@ -36,6 +36,10 @@
ViewController.prototype = {
loaded: function() {
+ this._mainContentElement = document.createElement('div');
+ document.body.appendChild(this._mainContentElement);
+ document.body.appendChild(this._domForAuxiliaryUIElements());
+
this.parseHash(location.hash);
},
@@ -97,11 +101,11 @@
var header = document.createElement('h1');
header.appendChild(document.createTextNode(builder.name));
- document.body.innerHTML = '';
+ self._mainContentElement.innerHTML = '';
document.title = builder.name;
- document.body.appendChild(header);
- document.body.appendChild(list);
- document.body.appendChild(self._domForPossiblyFlakyTests(builder, data.possiblyFlaky));
+ self._mainContentElement.appendChild(header);
+ self._mainContentElement.appendChild(list);
+ self._mainContentElement.appendChild(self._domForPossiblyFlakyTests(builder, data.possiblyFlaky));
if (!stillFetchingData)
PersistentCache.prune();
@@ -158,9 +162,9 @@
});
});
- document.body.innerHTML = '';
+ self._mainContentElement.innerHTML = '';
document.title = 'Testers';
- document.body.appendChild(list);
+ self._mainContentElement.appendChild(list);
});
},
@@ -192,6 +196,30 @@
return result;
},
+ _domForAuxiliaryUIElements: function() {
+ if (!this._bugzilla)
+ return document.createDocumentFragment();
+
+ var aside = document.createElement('aside');
+ aside.appendChild(document.createTextNode('Something not working? Have an idea to improve this page? '));
+ var link = document.createElement('a');
+ aside.appendChild(link);
+
+ link.appendChild(document.createTextNode('File a bug!'));
+ var queryParameters = {
+ product: 'WebKit',
+ component: 'Tools / Tests',
+ version: '528+ (Nightly build)',
+ bug_file_loc: location.href,
+ cc: '[email protected]',
+ short_desc: 'TestFailures page needs more unicorns!',
+ };
+ link.href = "" + 'enter_bug.cgi', queryParameters);
+ link.target = '_blank';
+
+ return aside;
+ },
+
_domForBuildName: function(builder, buildName) {
var parsed = this._buildbot.parseBuildName(buildName);
Modified: trunk/Tools/ChangeLog (90114 => 90115)
--- trunk/Tools/ChangeLog 2011-06-30 14:00:16 UTC (rev 90114)
+++ trunk/Tools/ChangeLog 2011-06-30 14:00:30 UTC (rev 90115)
@@ -1,5 +1,29 @@
2011-06-30 Adam Roben <[email protected]>
+ Add a link to file a bug about TestFailures to the TestFailures page
+
+ Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
+ about TestFailures itself
+
+ Reviewed by Anders Carlsson.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
+ (aside): Added some styles for the new link. It is positioned in the upper-right and
+ hopefully not to glaringly obvious.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+ (ViewController.prototype.loaded): Set up our main content element and auxiliary UI.
+
+ (ViewController.prototype._displayBuilder):
+ (ViewController.prototype._displayTesters):
+ Modify the main content element instead of the entire body, as there are other things in the
+ body that we want to preserve.
+
+ (ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
+ that contains a link to file a bug about the TestFailures page.
+
+2011-06-30 Adam Roben <[email protected]>
+
Ignore callbacks that correspond to old navigations of the TestFailures page
Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
