Title: [90118] trunk/Tools
- Revision
- 90118
- Author
- [email protected]
- Date
- 2011-06-30 07:30:19 -0700 (Thu, 30 Jun 2011)
Log Message
Show full commit logs when visiting Trac from TestFailures page
Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
should show full commit logs
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
verbose=on to the log URL to tell Trac to show full commit logs.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js (90117 => 90118)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-06-30 14:11:21 UTC (rev 90117)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-06-30 14:30:19 UTC (rev 90118)
@@ -32,7 +32,13 @@
return this.baseURL + 'changeset/' + revision;
},
- logURL: function(path, startRevision, endRevision) {
- return addQueryParametersToURL(this.baseURL + 'log/' + path, { rev: endRevision, stop_rev: startRevision });
+ logURL: function(path, startRevision, endRevision, showFullCommitLogs) {
+ var queryParameters = {
+ rev: endRevision,
+ stop_rev: startRevision,
+ };
+ if (showFullCommitLogs)
+ queryParameters.verbose = 'on';
+ return addQueryParametersToURL(this.baseURL + 'log/' + path, queryParameters);
},
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (90117 => 90118)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-06-30 14:11:21 UTC (rev 90117)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-06-30 14:30:19 UTC (rev 90118)
@@ -190,7 +190,7 @@
var link = document.createElement('a');
result.appendChild(link);
- link.href = "" firstSuspectRevision, lastSuspectRevision);
+ link.href = "" firstSuspectRevision, lastSuspectRevision, true);
link.appendChild(document.createTextNode('View regression range in Trac'));
return result;
Modified: trunk/Tools/ChangeLog (90117 => 90118)
--- trunk/Tools/ChangeLog 2011-06-30 14:11:21 UTC (rev 90117)
+++ trunk/Tools/ChangeLog 2011-06-30 14:30:19 UTC (rev 90118)
@@ -1,5 +1,21 @@
2011-06-30 Adam Roben <[email protected]>
+ Show full commit logs when visiting Trac from TestFailures page
+
+ Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
+ should show full commit logs
+
+ Reviewed by David Kilzer.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
+ (Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
+ verbose=on to the log URL to tell Trac to show full commit logs.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+ (ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.
+
+2011-06-30 Adam Roben <[email protected]>
+
Add a link to file a bug about TestFailures to the TestFailures page
Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
