Title: [90140] trunk/Tools
- Revision
- 90140
- Author
- [email protected]
- Date
- 2011-06-30 11:56:27 -0700 (Thu, 30 Jun 2011)
Log Message
2011-06-30 Eric Seidel <[email protected]>
Reviewed by Adam Barth.
Remove redundant tests in TestFailuresTest
https://bugs.webkit.org/show_bug.cgi?id=63742
These tests are all already covered by TestFailuresTest.test_loads.
I also added the missing "T" from TestFailuresest. :)
* Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90139 => 90140)
--- trunk/Tools/ChangeLog 2011-06-30 18:41:30 UTC (rev 90139)
+++ trunk/Tools/ChangeLog 2011-06-30 18:56:27 UTC (rev 90140)
@@ -1,3 +1,15 @@
+2011-06-30 Eric Seidel <[email protected]>
+
+ Reviewed by Adam Barth.
+
+ Remove redundant tests in TestFailuresTest
+ https://bugs.webkit.org/show_bug.cgi?id=63742
+
+ These tests are all already covered by TestFailuresTest.test_loads.
+ I also added the missing "T" from TestFailuresest. :)
+
+ * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
+
2011-06-30 Adam Barth <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py (90139 => 90140)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py 2011-06-30 18:41:30 UTC (rev 90139)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py 2011-06-30 18:56:27 UTC (rev 90140)
@@ -33,7 +33,7 @@
from webkitpy.layout_tests.layout_package.test_failures import *
-class TestFailuresest(unittest.TestCase):
+class TestFailuresTest(unittest.TestCase):
def assert_loads(self, cls):
failure_obj = cls()
s = failure_obj.dumps()
@@ -45,24 +45,6 @@
# Also test that != is implemented.
self.assertFalse(failure_obj != new_failure_obj)
- def test_crash(self):
- FailureCrash()
-
- def test_hash_incorrect(self):
- FailureImageHashIncorrect()
-
- def test_missing(self):
- FailureMissingResult()
-
- def test_missing_image(self):
- FailureMissingImage()
-
- def test_missing_image_hash(self):
- FailureMissingImageHash()
-
- def test_timeout(self):
- FailureTimeout()
-
def test_unknown_failure_type(self):
class UnknownFailure(TestFailure):
pass
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
