Title: [90202] trunk
- Revision
- 90202
- Author
- [email protected]
- Date
- 2011-06-30 20:54:58 -0700 (Thu, 30 Jun 2011)
Log Message
2011-06-30 Kent Tamura <[email protected]>
Reviewed by Tony Chang.
[Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=63697
* platform/chromium/test_expectations.txt: Some tests need new expectation images.
2011-06-30 Kent Tamura <[email protected]>
Reviewed by Tony Chang.
[Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=63697
http://trac.webkit.org/changeset/86261 added a thumb flipping code
for Mac-WebKit2. Chromium also needs it.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90201 => 90202)
--- trunk/LayoutTests/ChangeLog 2011-07-01 03:31:51 UTC (rev 90201)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 03:54:58 UTC (rev 90202)
@@ -1,3 +1,12 @@
+2011-06-30 Kent Tamura <[email protected]>
+
+ Reviewed by Tony Chang.
+
+ [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
+ https://bugs.webkit.org/show_bug.cgi?id=63697
+
+ * platform/chromium/test_expectations.txt: Some tests need new expectation images.
+
2011-06-30 Kenichi Ishibashi <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90201 => 90202)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 03:31:51 UTC (rev 90201)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 03:54:58 UTC (rev 90202)
@@ -2990,6 +2990,13 @@
BUGWK54322 SNOWLEOPARD : svg/custom/acid3-test-77.html = TIMEOUT PASS
BUGWK54322 SNOWLEOPARD : transitions/transition-end-event-rendering.html = PASS TEXT
+BUGWK63697 MAC : fast/dom/HTMLInputElement/input-slider-update.html = IMAGE
+BUGWK63697 MAC : fast/forms/input-appearance-range.html = IMAGE
+BUGWK63697 MAC : fast/forms/slider-padding.html = IMAGE
+BUGWK63697 MAC : fast/forms/slider-thumb-shared-style.html = IMAGE
+BUGWK63697 MAC : fast/forms/thumbslider-no-parent-slider.html = IMAGE
+BUGWK63697 MAC : fast/repaint/slider-thumb-drag-release.html = IMAGE
+
// Release definitely renders wrong; debug differences from reference may just
// need rebaseline.
BUGWK54499 LINUX : svg/transforms/text-with-pattern-with-svg-transform.svg = IMAGE
Modified: trunk/Source/WebCore/ChangeLog (90201 => 90202)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 03:31:51 UTC (rev 90201)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 03:54:58 UTC (rev 90202)
@@ -1,3 +1,16 @@
+2011-06-30 Kent Tamura <[email protected]>
+
+ Reviewed by Tony Chang.
+
+ [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
+ https://bugs.webkit.org/show_bug.cgi?id=63697
+
+ http://trac.webkit.org/changeset/86261 added a thumb flipping code
+ for Mac-WebKit2. Chromium also needs it.
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.
+
2011-06-30 Kenichi Ishibashi <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (90201 => 90202)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2011-07-01 03:31:51 UTC (rev 90201)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2011-07-01 03:54:58 UTC (rev 90202)
@@ -1365,6 +1365,10 @@
paintInfo.context->scale(FloatSize(1, -1));
paintInfo.context->translate(0, -(unzoomedRect.y() + unzoomedRect.height()));
}
+#elif PLATFORM(CHROMIUM)
+ paintInfo.context->translate(0, unzoomedRect.y());
+ paintInfo.context->scale(FloatSize(1, -1));
+ paintInfo.context->translate(0, -(unzoomedRect.y() + unzoomedRect.height()));
#endif
[sliderThumbCell drawInteriorWithFrame:unzoomedRect inView:documentViewFor(o)];
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
