Title: [90206] trunk/Source/WebKit/chromium
- Revision
- 90206
- Author
- [email protected]
- Date
- 2011-06-30 23:06:59 -0700 (Thu, 30 Jun 2011)
Log Message
2011-06-30 Noel Gordon <[email protected]>
Reviewed by Hajime Morita.
[Chromium] Remove WebBindings::makeNode.
https://bugs.webkit.org/show_bug.cgi?id=63613
Dead code elimination. No change in behaviour, so no new tests.
* public/WebBindings.h:
* src/WebBindings.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (90205 => 90206)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 05:47:29 UTC (rev 90205)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 06:06:59 UTC (rev 90206)
@@ -1,3 +1,15 @@
+2011-06-30 Noel Gordon <[email protected]>
+
+ Reviewed by Hajime Morita.
+
+ [Chromium] Remove WebBindings::makeNode.
+ https://bugs.webkit.org/show_bug.cgi?id=63613
+
+ Dead code elimination. No change in behaviour, so no new tests.
+
+ * public/WebBindings.h:
+ * src/WebBindings.cpp:
+
2011-06-30 Kent Tamura <[email protected]>
Reviewed by Darin Fisher.
Modified: trunk/Source/WebKit/chromium/public/WebBindings.h (90205 => 90206)
--- trunk/Source/WebKit/chromium/public/WebBindings.h 2011-07-01 05:47:29 UTC (rev 90205)
+++ trunk/Source/WebKit/chromium/public/WebBindings.h 2011-07-01 06:06:59 UTC (rev 90206)
@@ -128,6 +128,8 @@
// undefined. If iString is false, the opposite is true.
WEBKIT_API static void extractIdentifierData(const NPIdentifier&, const NPUTF8*& string, int32_t& number, bool& isString);
+ // DumpRenderTree support -------------------------------------------------
+
// Return true (success) if the given npobj is a range object.
// If so, return that range as a WebRange object.
WEBKIT_API static bool getRange(NPObject* range, WebRange*);
@@ -138,7 +140,6 @@
WEBKIT_API static NPObject* makeIntArray(const WebVector<int>&);
WEBKIT_API static NPObject* makeStringArray(const WebVector<WebString>&);
- WEBKIT_API static NPObject* makeNode(const WebNode&);
// Exceptions -------------------------------------------------------------
Modified: trunk/Source/WebKit/chromium/src/WebBindings.cpp (90205 => 90206)
--- trunk/Source/WebKit/chromium/src/WebBindings.cpp 2011-07-01 05:47:29 UTC (rev 90205)
+++ trunk/Source/WebKit/chromium/src/WebBindings.cpp 2011-07-01 06:06:59 UTC (rev 90206)
@@ -41,7 +41,6 @@
#include "V8DOMWrapper.h"
#include "V8Element.h"
#include "V8NPUtils.h"
-#include "V8Node.h"
#include "V8Proxy.h"
#include "V8Range.h"
#elif USE(JSC)
@@ -257,16 +256,6 @@
return npCreateV8ScriptObject(0, result, window);
}
-static NPObject* makeNodeImpl(WebNode data)
-{
- v8::HandleScope handleScope;
- if (data.isNull())
- return 0;
- v8::Handle<v8::Object> result = V8Node::wrap(data.unwrap<Node>());
- WebCore::DOMWindow* window = WebCore::V8Proxy::retrieveWindow(WebCore::V8Proxy::currentContext());
- return npCreateV8ScriptObject(0, result, window);
-}
-
#endif
bool WebBindings::getRange(NPObject* range, WebRange* webRange)
@@ -309,16 +298,6 @@
#endif
}
-NPObject* WebBindings::makeNode(const WebNode& data)
-{
-#if USE(V8)
- return makeNodeImpl(data);
-#else
- // Not supported on other ports (JSC, etc.).
- return 0;
-#endif
-}
-
void WebBindings::pushExceptionHandler(ExceptionHandler handler, void* data)
{
WebCore::pushExceptionHandler(handler, data);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
