Title: [90252] trunk
- Revision
- 90252
- Author
- [email protected]
- Date
- 2011-07-01 11:40:18 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Hans Wennborg <[email protected]>
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/constants.html:
2011-07-01 Hans Wennborg <[email protected]>
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
constants. Douglas Stockwell pointed out that these were reverse
of what the spec says.
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90251 => 90252)
--- trunk/LayoutTests/ChangeLog 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 18:40:18 UTC (rev 90252)
@@ -1,3 +1,16 @@
+2011-07-01 Hans Wennborg <[email protected]>
+
+ Reviewed by Tony Chang.
+
+ IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
+ https://bugs.webkit.org/show_bug.cgi?id=63754
+
+ Update layout tests to use the right values for
+ webkitIDBTransaction.READ_WRITE/READ_ONLY.
+
+ * storage/indexeddb/constants-expected.txt:
+ * storage/indexeddb/constants.html:
+
2011-07-01 Gavin Barraclough <[email protected]>
Reviewed by Sam Weinig.
Modified: trunk/LayoutTests/storage/indexeddb/constants-expected.txt (90251 => 90252)
--- trunk/LayoutTests/storage/indexeddb/constants-expected.txt 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/LayoutTests/storage/indexeddb/constants-expected.txt 2011-07-01 18:40:18 UTC (rev 90252)
@@ -20,8 +20,8 @@
PASS webkitIDBCursor.NEXT_NO_DUPLICATE is 1
PASS webkitIDBCursor.PREV is 2
PASS webkitIDBCursor.PREV_NO_DUPLICATE is 3
-PASS webkitIDBTransaction.READ_WRITE is 0
-PASS webkitIDBTransaction.READ_ONLY is 1
+PASS webkitIDBTransaction.READ_ONLY is 0
+PASS webkitIDBTransaction.READ_WRITE is 1
PASS webkitIDBTransaction.VERSION_CHANGE is 2
PASS successfullyParsed is true
Modified: trunk/LayoutTests/storage/indexeddb/constants.html (90251 => 90252)
--- trunk/LayoutTests/storage/indexeddb/constants.html 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/LayoutTests/storage/indexeddb/constants.html 2011-07-01 18:40:18 UTC (rev 90252)
@@ -36,8 +36,8 @@
shouldBe("webkitIDBCursor.PREV", "2");
shouldBe("webkitIDBCursor.PREV_NO_DUPLICATE", "3");
- shouldBe("webkitIDBTransaction.READ_WRITE", "0");
- shouldBe("webkitIDBTransaction.READ_ONLY", "1");
+ shouldBe("webkitIDBTransaction.READ_ONLY", "0");
+ shouldBe("webkitIDBTransaction.READ_WRITE", "1");
shouldBe("webkitIDBTransaction.VERSION_CHANGE", "2");
}
Modified: trunk/Source/WebCore/ChangeLog (90251 => 90252)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 18:40:18 UTC (rev 90252)
@@ -1,3 +1,17 @@
+2011-07-01 Hans Wennborg <[email protected]>
+
+ Reviewed by Tony Chang.
+
+ IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
+ https://bugs.webkit.org/show_bug.cgi?id=63754
+
+ Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
+ constants. Douglas Stockwell pointed out that these were reverse
+ of what the spec says.
+
+ * storage/IDBTransaction.h:
+ * storage/IDBTransaction.idl:
+
2011-07-01 Levi Weintraub <[email protected]>
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/storage/IDBTransaction.h (90251 => 90252)
--- trunk/Source/WebCore/storage/IDBTransaction.h 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/Source/WebCore/storage/IDBTransaction.h 2011-07-01 18:40:18 UTC (rev 90252)
@@ -49,8 +49,8 @@
virtual ~IDBTransaction();
enum Mode {
- READ_WRITE = 0,
- READ_ONLY = 1,
+ READ_ONLY = 0,
+ READ_WRITE = 1,
VERSION_CHANGE = 2
};
Modified: trunk/Source/WebCore/storage/IDBTransaction.idl (90251 => 90252)
--- trunk/Source/WebCore/storage/IDBTransaction.idl 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/Source/WebCore/storage/IDBTransaction.idl 2011-07-01 18:40:18 UTC (rev 90252)
@@ -33,8 +33,8 @@
EventTarget
] IDBTransaction {
// Modes
- const unsigned short READ_WRITE = 0;
- const unsigned short READ_ONLY = 1;
+ const unsigned short READ_ONLY = 0;
+ const unsigned short READ_WRITE = 1;
const unsigned short VERSION_CHANGE = 2;
// Properties
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
