Title: [90271] trunk/Source/WebCore
Revision
90271
Author
[email protected]
Date
2011-07-01 13:29:55 -0700 (Fri, 01 Jul 2011)

Log Message

2011-07-01  Tony Chang  <[email protected]>

        cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
        https://bugs.webkit.org/show_bug.cgi?id=63827

        Reviewed by Ojan Vafai.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::diff):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::boxAlign):
        (WebCore::InheritedFlags::boxFlex):
        (WebCore::InheritedFlags::boxFlexGroup):
        (WebCore::InheritedFlags::boxLines):
        (WebCore::InheritedFlags::boxOrdinalGroup):
        (WebCore::InheritedFlags::boxOrient):
        (WebCore::InheritedFlags::boxPack):
        (WebCore::InheritedFlags::marqueeIncrement):
        (WebCore::InheritedFlags::marqueeSpeed):
        (WebCore::InheritedFlags::marqueeLoopCount):
        (WebCore::InheritedFlags::marqueeBehavior):
        (WebCore::InheritedFlags::marqueeDirection):
        (WebCore::InheritedFlags::setBoxAlign):
        (WebCore::InheritedFlags::setBoxFlex):
        (WebCore::InheritedFlags::setBoxFlexGroup):
        (WebCore::InheritedFlags::setBoxLines):
        (WebCore::InheritedFlags::setBoxOrdinalGroup):
        (WebCore::InheritedFlags::setBoxOrient):
        (WebCore::InheritedFlags::setBoxPack):
        (WebCore::InheritedFlags::setMarqueeIncrement):
        (WebCore::InheritedFlags::setMarqueeSpeed):
        (WebCore::InheritedFlags::setMarqueeDirection):
        (WebCore::InheritedFlags::setMarqueeBehavior):
        (WebCore::InheritedFlags::setMarqueeLoopCount):
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        * rendering/style/StyleRareNonInheritedData.h:
            flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (90270 => 90271)


--- trunk/Source/WebCore/ChangeLog	2011-07-01 20:27:46 UTC (rev 90270)
+++ trunk/Source/WebCore/ChangeLog	2011-07-01 20:29:55 UTC (rev 90271)
@@ -1,3 +1,44 @@
+2011-07-01  Tony Chang  <[email protected]>
+
+        cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
+        https://bugs.webkit.org/show_bug.cgi?id=63827
+
+        Reviewed by Ojan Vafai.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::RenderStyle):
+        (WebCore::RenderStyle::diff):
+        * rendering/style/RenderStyle.h:
+        (WebCore::InheritedFlags::boxAlign):
+        (WebCore::InheritedFlags::boxFlex):
+        (WebCore::InheritedFlags::boxFlexGroup):
+        (WebCore::InheritedFlags::boxLines):
+        (WebCore::InheritedFlags::boxOrdinalGroup):
+        (WebCore::InheritedFlags::boxOrient):
+        (WebCore::InheritedFlags::boxPack):
+        (WebCore::InheritedFlags::marqueeIncrement):
+        (WebCore::InheritedFlags::marqueeSpeed):
+        (WebCore::InheritedFlags::marqueeLoopCount):
+        (WebCore::InheritedFlags::marqueeBehavior):
+        (WebCore::InheritedFlags::marqueeDirection):
+        (WebCore::InheritedFlags::setBoxAlign):
+        (WebCore::InheritedFlags::setBoxFlex):
+        (WebCore::InheritedFlags::setBoxFlexGroup):
+        (WebCore::InheritedFlags::setBoxLines):
+        (WebCore::InheritedFlags::setBoxOrdinalGroup):
+        (WebCore::InheritedFlags::setBoxOrient):
+        (WebCore::InheritedFlags::setBoxPack):
+        (WebCore::InheritedFlags::setMarqueeIncrement):
+        (WebCore::InheritedFlags::setMarqueeSpeed):
+        (WebCore::InheritedFlags::setMarqueeDirection):
+        (WebCore::InheritedFlags::setMarqueeBehavior):
+        (WebCore::InheritedFlags::setMarqueeLoopCount):
+        * rendering/style/StyleRareNonInheritedData.cpp:
+        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
+        (WebCore::StyleRareNonInheritedData::operator==):
+        * rendering/style/StyleRareNonInheritedData.h:
+            flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee
+
 2011-07-01  Mike Reed  <[email protected]>
 
         Stop using deprecated SkDeviceFactory API

Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (90270 => 90271)


--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2011-07-01 20:27:46 UTC (rev 90270)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2011-07-01 20:29:55 UTC (rev 90271)
@@ -117,8 +117,8 @@
     m_background.init();
     surround.init();
     rareNonInheritedData.init();
-    rareNonInheritedData.access()->flexibleBox.init();
-    rareNonInheritedData.access()->marquee.init();
+    rareNonInheritedData.access()->m_deprecatedFlexibleBox.init();
+    rareNonInheritedData.access()->m_marquee.init();
     rareNonInheritedData.access()->m_multiCol.init();
     rareNonInheritedData.access()->m_transform.init();
     rareInheritedData.init();
@@ -344,8 +344,8 @@
             || rareNonInheritedData->textOverflow != other->rareNonInheritedData->textOverflow)
             return StyleDifferenceLayout;
 
-        if (rareNonInheritedData->flexibleBox.get() != other->rareNonInheritedData->flexibleBox.get()
-            && *rareNonInheritedData->flexibleBox.get() != *other->rareNonInheritedData->flexibleBox.get())
+        if (rareNonInheritedData->m_deprecatedFlexibleBox.get() != other->rareNonInheritedData->m_deprecatedFlexibleBox.get()
+            && *rareNonInheritedData->m_deprecatedFlexibleBox.get() != *other->rareNonInheritedData->m_deprecatedFlexibleBox.get())
             return StyleDifferenceLayout;
 
         // FIXME: We should add an optimized form of layout that just recomputes visual overflow.

Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (90270 => 90271)


--- trunk/Source/WebCore/rendering/style/RenderStyle.h	2011-07-01 20:27:46 UTC (rev 90270)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h	2011-07-01 20:29:55 UTC (rev 90271)
@@ -661,14 +661,14 @@
     ColorSpace colorSpace() const { return static_cast<ColorSpace>(rareInheritedData->colorSpace); }
     float opacity() const { return rareNonInheritedData->opacity; }
     ControlPart appearance() const { return static_cast<ControlPart>(rareNonInheritedData->m_appearance); }
-    EBoxAlignment boxAlign() const { return static_cast<EBoxAlignment>(rareNonInheritedData->flexibleBox->align); }
+    EBoxAlignment boxAlign() const { return static_cast<EBoxAlignment>(rareNonInheritedData->m_deprecatedFlexibleBox->align); }
     EBoxDirection boxDirection() const { return static_cast<EBoxDirection>(inherited_flags._box_direction); }
-    float boxFlex() { return rareNonInheritedData->flexibleBox->flex; }
-    unsigned int boxFlexGroup() const { return rareNonInheritedData->flexibleBox->flex_group; }
-    EBoxLines boxLines() { return static_cast<EBoxLines>(rareNonInheritedData->flexibleBox->lines); }
-    unsigned int boxOrdinalGroup() const { return rareNonInheritedData->flexibleBox->ordinal_group; }
-    EBoxOrient boxOrient() const { return static_cast<EBoxOrient>(rareNonInheritedData->flexibleBox->orient); }
-    EBoxAlignment boxPack() const { return static_cast<EBoxAlignment>(rareNonInheritedData->flexibleBox->pack); }
+    float boxFlex() { return rareNonInheritedData->m_deprecatedFlexibleBox->flex; }
+    unsigned int boxFlexGroup() const { return rareNonInheritedData->m_deprecatedFlexibleBox->flex_group; }
+    EBoxLines boxLines() { return static_cast<EBoxLines>(rareNonInheritedData->m_deprecatedFlexibleBox->lines); }
+    unsigned int boxOrdinalGroup() const { return rareNonInheritedData->m_deprecatedFlexibleBox->ordinal_group; }
+    EBoxOrient boxOrient() const { return static_cast<EBoxOrient>(rareNonInheritedData->m_deprecatedFlexibleBox->orient); }
+    EBoxAlignment boxPack() const { return static_cast<EBoxAlignment>(rareNonInheritedData->m_deprecatedFlexibleBox->pack); }
 
     const ShadowData* boxShadow() const { return rareNonInheritedData->m_boxShadow.get(); }
     void getBoxShadowExtent(int& top, int& right, int& bottom, int& left) const { getShadowExtent(boxShadow(), top, right, bottom, left); }
@@ -679,11 +679,11 @@
 
     StyleReflection* boxReflect() const { return rareNonInheritedData->m_boxReflect.get(); }
     EBoxSizing boxSizing() const { return m_box->boxSizing(); }
-    Length marqueeIncrement() const { return rareNonInheritedData->marquee->increment; }
-    int marqueeSpeed() const { return rareNonInheritedData->marquee->speed; }
-    int marqueeLoopCount() const { return rareNonInheritedData->marquee->loops; }
-    EMarqueeBehavior marqueeBehavior() const { return static_cast<EMarqueeBehavior>(rareNonInheritedData->marquee->behavior); }
-    EMarqueeDirection marqueeDirection() const { return static_cast<EMarqueeDirection>(rareNonInheritedData->marquee->direction); }
+    Length marqueeIncrement() const { return rareNonInheritedData->m_marquee->increment; }
+    int marqueeSpeed() const { return rareNonInheritedData->m_marquee->speed; }
+    int marqueeLoopCount() const { return rareNonInheritedData->m_marquee->loops; }
+    EMarqueeBehavior marqueeBehavior() const { return static_cast<EMarqueeBehavior>(rareNonInheritedData->m_marquee->behavior); }
+    EMarqueeDirection marqueeDirection() const { return static_cast<EMarqueeDirection>(rareNonInheritedData->m_marquee->direction); }
     EUserModify userModify() const { return static_cast<EUserModify>(rareInheritedData->userModify); }
     EUserDrag userDrag() const { return static_cast<EUserDrag>(rareNonInheritedData->userDrag); }
     EUserSelect userSelect() const { return static_cast<EUserSelect>(rareInheritedData->userSelect); }
@@ -1027,22 +1027,22 @@
     void setOpacity(float f) { SET_VAR(rareNonInheritedData, opacity, f); }
     void setAppearance(ControlPart a) { SET_VAR(rareNonInheritedData, m_appearance, a); }
     // For valid values of box-align see http://www.w3.org/TR/2009/WD-css3-flexbox-20090723/#alignment
-    void setBoxAlign(EBoxAlignment a) { ASSERT(a == BSTRETCH || a == BSTART || a == BCENTER || a == BEND || a == BBASELINE); SET_VAR(rareNonInheritedData.access()->flexibleBox, align, a); }
+    void setBoxAlign(EBoxAlignment a) { ASSERT(a == BSTRETCH || a == BSTART || a == BCENTER || a == BEND || a == BBASELINE); SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, align, a); }
     void setBoxDirection(EBoxDirection d) { inherited_flags._box_direction = d; }
-    void setBoxFlex(float f) { SET_VAR(rareNonInheritedData.access()->flexibleBox, flex, f); }
-    void setBoxFlexGroup(unsigned int fg) { SET_VAR(rareNonInheritedData.access()->flexibleBox, flex_group, fg); }
-    void setBoxLines(EBoxLines l) { SET_VAR(rareNonInheritedData.access()->flexibleBox, lines, l); }
-    void setBoxOrdinalGroup(unsigned int og) { SET_VAR(rareNonInheritedData.access()->flexibleBox, ordinal_group, og); }
-    void setBoxOrient(EBoxOrient o) { SET_VAR(rareNonInheritedData.access()->flexibleBox, orient, o); }
-    void setBoxPack(EBoxAlignment p) { SET_VAR(rareNonInheritedData.access()->flexibleBox, pack, p); }
+    void setBoxFlex(float f) { SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, flex, f); }
+    void setBoxFlexGroup(unsigned int fg) { SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, flex_group, fg); }
+    void setBoxLines(EBoxLines l) { SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, lines, l); }
+    void setBoxOrdinalGroup(unsigned int og) { SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, ordinal_group, og); }
+    void setBoxOrient(EBoxOrient o) { SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, orient, o); }
+    void setBoxPack(EBoxAlignment p) { SET_VAR(rareNonInheritedData.access()->m_deprecatedFlexibleBox, pack, p); }
     void setBoxShadow(PassOwnPtr<ShadowData>, bool add = false);
     void setBoxReflect(PassRefPtr<StyleReflection> reflect) { if (rareNonInheritedData->m_boxReflect != reflect) rareNonInheritedData.access()->m_boxReflect = reflect; }
     void setBoxSizing(EBoxSizing s) { SET_VAR(m_box, m_boxSizing, s); }
-    void setMarqueeIncrement(const Length& f) { SET_VAR(rareNonInheritedData.access()->marquee, increment, f); }
-    void setMarqueeSpeed(int f) { SET_VAR(rareNonInheritedData.access()->marquee, speed, f); }
-    void setMarqueeDirection(EMarqueeDirection d) { SET_VAR(rareNonInheritedData.access()->marquee, direction, d); }
-    void setMarqueeBehavior(EMarqueeBehavior b) { SET_VAR(rareNonInheritedData.access()->marquee, behavior, b); }
-    void setMarqueeLoopCount(int i) { SET_VAR(rareNonInheritedData.access()->marquee, loops, i); }
+    void setMarqueeIncrement(const Length& f) { SET_VAR(rareNonInheritedData.access()->m_marquee, increment, f); }
+    void setMarqueeSpeed(int f) { SET_VAR(rareNonInheritedData.access()->m_marquee, speed, f); }
+    void setMarqueeDirection(EMarqueeDirection d) { SET_VAR(rareNonInheritedData.access()->m_marquee, direction, d); }
+    void setMarqueeBehavior(EMarqueeBehavior b) { SET_VAR(rareNonInheritedData.access()->m_marquee, behavior, b); }
+    void setMarqueeLoopCount(int i) { SET_VAR(rareNonInheritedData.access()->m_marquee, loops, i); }
     void setUserModify(EUserModify u) { SET_VAR(rareInheritedData, userModify, u); }
     void setUserDrag(EUserDrag d) { SET_VAR(rareNonInheritedData, userDrag, d); }
     void setUserSelect(EUserSelect s) { SET_VAR(rareInheritedData, userSelect, s); }

Modified: trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp (90270 => 90271)


--- trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp	2011-07-01 20:27:46 UTC (rev 90270)
+++ trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp	2011-07-01 20:29:55 UTC (rev 90271)
@@ -62,8 +62,8 @@
     : RefCounted<StyleRareNonInheritedData>()
     , lineClamp(o.lineClamp)
     , opacity(o.opacity)
-    , flexibleBox(o.flexibleBox)
-    , marquee(o.marquee)
+    , m_deprecatedFlexibleBox(o.m_deprecatedFlexibleBox)
+    , m_marquee(o.m_marquee)
     , m_multiCol(o.m_multiCol)
     , m_transform(o.m_transform)
     , m_content(o.m_content ? o.m_content->clone() : nullptr)
@@ -108,8 +108,8 @@
         && m_dashboardRegions == o.m_dashboardRegions
 #endif
         && opacity == o.opacity
-        && flexibleBox == o.flexibleBox
-        && marquee == o.marquee
+        && m_deprecatedFlexibleBox == o.m_deprecatedFlexibleBox
+        && m_marquee == o.m_marquee
         && m_multiCol == o.m_multiCol
         && m_transform == o.m_transform
         && contentDataEquivalent(o)

Modified: trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h (90270 => 90271)


--- trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h	2011-07-01 20:27:46 UTC (rev 90270)
+++ trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h	2011-07-01 20:29:55 UTC (rev 90271)
@@ -89,8 +89,8 @@
 #endif
     float opacity; // Whether or not we're transparent.
 
-    DataRef<StyleDeprecatedFlexibleBoxData> flexibleBox; // Flexible box properties
-    DataRef<StyleMarqueeData> marquee; // Marquee properties
+    DataRef<StyleDeprecatedFlexibleBoxData> m_deprecatedFlexibleBox; // Flexible box properties
+    DataRef<StyleMarqueeData> m_marquee; // Marquee properties
     DataRef<StyleMultiColData> m_multiCol; //  CSS3 multicol properties
     DataRef<StyleTransformData> m_transform; // Transform properties (rotate, scale, skew, etc.)
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to