Title: [90355] trunk
- Revision
- 90355
- Author
- [email protected]
- Date
- 2011-07-04 02:20:15 -0700 (Mon, 04 Jul 2011)
Log Message
2011-07-04 Andrey Kosyakov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] audit formatter names should begin with create
https://bugs.webkit.org/show_bug.cgi?id=63802
* inspector/extensions/extensions-audits-api-expected.txt:
* inspector/extensions/extensions-audits.html:
2011-07-04 Andrey Kosyakov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] audit formatter names should begin with create
https://bugs.webkit.org/show_bug.cgi?id=63802
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.AuditResultImpl):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90354 => 90355)
--- trunk/LayoutTests/ChangeLog 2011-07-04 09:18:37 UTC (rev 90354)
+++ trunk/LayoutTests/ChangeLog 2011-07-04 09:20:15 UTC (rev 90355)
@@ -1,3 +1,13 @@
+2011-07-04 Andrey Kosyakov <[email protected]>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: [Extensions API] audit formatter names should begin with create
+ https://bugs.webkit.org/show_bug.cgi?id=63802
+
+ * inspector/extensions/extensions-audits-api-expected.txt:
+ * inspector/extensions/extensions-audits.html:
+
2011-07-04 Yuta Kitamura <[email protected]>
WebSocket: Use jsTestIsAsync and finishJSTest() wherever possible in WebSocket tests
Modified: trunk/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt (90354 => 90355)
--- trunk/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt 2011-07-04 09:18:37 UTC (rev 90354)
+++ trunk/LayoutTests/inspector/extensions/extensions-audits-api-expected.txt 2011-07-04 09:20:15 UTC (rev 90355)
@@ -13,9 +13,9 @@
Extension audits
category.onAuditStarted fired, results dump follows:
{
- url : <function>
- snippet : <function>
- text : <function>
+ createURL : <function>
+ createSnippet : <function>
+ createText : <function>
addResult : <function>
createResult : <function>
done : <function>
Modified: trunk/LayoutTests/inspector/extensions/extensions-audits.html (90354 => 90355)
--- trunk/LayoutTests/inspector/extensions/extensions-audits.html 2011-07-04 09:18:37 UTC (rev 90354)
+++ trunk/LayoutTests/inspector/extensions/extensions-audits.html 2011-07-04 09:20:15 UTC (rev 90355)
@@ -16,10 +16,10 @@
results.addResult("Failed rule (42)", "this rule always fails", results.Severity.Severe);
var node = results.createResult("Subtree");
- node.addChild("Some url: ", results.url("http://www.webkit.org", "WebKit"), " more text ", results.url("http://www.google.com"));
+ node.addChild("Some url: ", results.createURL("http://www.webkit.org", "WebKit"), " more text ", results.createURL("http://www.google.com"));
var nestedNode = node.addChild("... and a snippet");
nestedNode.expanded = true;
- nestedNode.addChild(results.snippet("function rand()\n{\n return 4;\n}"));
+ nestedNode.addChild(results.createSnippet("function rand()\n{\n return 4;\n}"));
results.addResult("Rule with details subtree (1)", "This rule has a lot of details", results.Severity.Warning, node);
// Audit normally terminates when number of added rule results is equal to
Modified: trunk/Source/WebCore/ChangeLog (90354 => 90355)
--- trunk/Source/WebCore/ChangeLog 2011-07-04 09:18:37 UTC (rev 90354)
+++ trunk/Source/WebCore/ChangeLog 2011-07-04 09:20:15 UTC (rev 90355)
@@ -1,3 +1,13 @@
+2011-07-04 Andrey Kosyakov <[email protected]>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: [Extensions API] audit formatter names should begin with create
+ https://bugs.webkit.org/show_bug.cgi?id=63802
+
+ * inspector/front-end/ExtensionAPI.js:
+ (WebInspector.injectedExtensionAPI.AuditResultImpl):
+
2011-07-03 Dominic Cooney <[email protected]>
The value property of an indeterminate progress element should be zero
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (90354 => 90355)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-07-04 09:18:37 UTC (rev 90354)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-07-04 09:20:15 UTC (rev 90355)
@@ -287,13 +287,9 @@
{
this._id = id;
- var formatterTypes = [
- "url",
- "snippet",
- "text"
- ];
- for (var i = 0; i < formatterTypes.length; ++i)
- this[formatterTypes[i]] = bind(this._nodeFactory, null, formatterTypes[i]);
+ this.createURL = bind(this._nodeFactory, null, "url");
+ this.createSnippet = bind(this._nodeFactory, null, "snippet");
+ this.createText = bind(this._nodeFactory, null, "text");
}
AuditResultImpl.prototype = {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
